Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: condition and combat immunities/suppression/damage #1405

Merged

Conversation

dudantas
Copy link
Member

Fixed some bugs related to Condition and Combat.

@dudantas dudantas force-pushed the fix-conditions-and-combat-immunities/damage branch from 0968afe to 2b50876 Compare August 15, 2023 01:49
@dudantas dudantas linked an issue Aug 15, 2023 that may be closed by this pull request
5 tasks
@aokisama
Copy link
Contributor

Seems to run fine on windows, on ubuntu 20.04 I got this error

image

@dudantas
Copy link
Member Author

Seems to run fine on windows, on ubuntu 20.04 I got this error

image

Ok, I'll have to set up a build environment to test.

@dudantas
Copy link
Member Author

Seems to run fine on windows, on ubuntu 20.04 I got this error

image

You can test again, please?

@dudantas dudantas force-pushed the fix-conditions-and-combat-immunities/damage branch from eb5f077 to d3f0821 Compare August 15, 2023 19:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.3% 2.3% Duplication

@dudantas dudantas merged commit 46b3c16 into opentibiabr:main Aug 16, 2023
@dudantas dudantas deleted the fix-conditions-and-combat-immunities/damage branch August 16, 2023 17:44
lgrossi pushed a commit to dudantas/canary that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dwarven ring not working
3 participants