Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: primal menace mechanics #1415

Merged
merged 26 commits into from
Aug 26, 2023

Conversation

sebbesiren
Copy link
Contributor

Description

Added kill events for magma bubble and primal menace in order to access hazard level in gnomprona.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just a few adjustments that must be made. Pass pointers to "addEvent" as "id" and create the objects in there, remove some unnecessary parentheses and fix some ifs.

@sebbesiren
Copy link
Contributor Author

Will fix in a day or two 😊

@luan luan changed the title feat: magma bubble and primal menace death event feat: primal menace mechanics Aug 23, 2023
@dudantas dudantas merged commit 2077604 into opentibiabr:main Aug 26, 2023
JasterDesu pushed a commit to JasterDesu/canary that referenced this pull request Sep 16, 2023
Added kill events for magma bubble and primal menace in order to access hazard level in gnomprona.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants