feat: Move CMake sources to subdirectories #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsongabriel
approved these changes
Aug 21, 2023
CMake is designed to be modular, meaning that each subdirectory is aware and responsible of it own needs, dependencies and includes. Previously, it was really hard to make this separation because our CMake files were huge and organized in a kinda of all-in-one file. With the recent CMake improvements, we can leverage CMake sub directories to make our includes more moduler and easier to read, instead of having a one imense single source of truth file.
lgrossi
force-pushed
the
feat/move-cmake-sources-to-sub-directories
branch
from
b8eae16 to
54494b2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake is designed to be modular, meaning that each subdirectory is aware and responsible of it own needs, dependencies and includes.
Previously, it was really hard to make this separation because our CMake files were huge and organized in a kinda of all-in-one file. With the recent CMake improvements, we can leverage CMake sub directories to make our includes more moduler and easier to read, instead of having a one imense single source of truth file.