Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show vip xp bonus on exp rate at skills #1496

Merged
merged 4 commits into from
Aug 26, 2023

Conversation

ruansvictor2
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behaviour

Actual

When enable vip system with bonus exp, and you enable the XP_DISPLAY_MODE to true, the bonus is not show

Expected

When enable vip system with bonus exp, and you enable the XP_DISPLAY_MODE to true shows the complete amount of exp gain

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [X ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Login and tests if the xp amount is shoing correctly.

  • [
    image
    ] Test A
  • [
    image
    ] Test B

Test Configuration:

  • Server Version:
  • Client:13.20
  • Operating System: Windows + WSL

@ruansvictor2
Copy link
Contributor Author

More tests with nonvip player
image

@ruansvictor2
Copy link
Contributor Author

tests com store xp boost
image

@elsongabriel elsongabriel changed the title Fix to show vip xp bonus on exp rate at skills fix: show vip xp bonus on exp rate at skills Aug 23, 2023
@ruansvictor2
Copy link
Contributor Author

New tests aftes resolve requests:
image

Copy link
Contributor Author

@ruansvictor2 ruansvictor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@ruansvictor2 ruansvictor2 force-pushed the feat/show-vip-bonus-skill-exp branch from 946a359 to fc460b6 Compare August 24, 2023 15:03
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@luan luan merged commit 87e9212 into opentibiabr:main Aug 26, 2023
JasterDesu pushed a commit to JasterDesu/canary that referenced this pull request Sep 16, 2023
When enable vip system with bonus exp, and you enable the
XP_DISPLAY_MODE to true shows the complete amount of exp gain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants