-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show vip xp bonus on exp rate at skills #1496
Merged
luan
merged 4 commits into
opentibiabr:main
from
ruansvictor2:feat/show-vip-bonus-skill-exp
Aug 26, 2023
Merged
fix: show vip xp bonus on exp rate at skills #1496
luan
merged 4 commits into
opentibiabr:main
from
ruansvictor2:feat/show-vip-bonus-skill-exp
Aug 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsongabriel
suggested changes
Aug 23, 2023
ruansvictor2
commented
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
946a359
to
fc460b6
Compare
dudantas
requested changes
Aug 26, 2023
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
luan
approved these changes
Aug 26, 2023
dudantas
approved these changes
Aug 26, 2023
elsongabriel
approved these changes
Aug 26, 2023
JasterDesu
pushed a commit
to JasterDesu/canary
that referenced
this pull request
Sep 16, 2023
When enable vip system with bonus exp, and you enable the XP_DISPLAY_MODE to true shows the complete amount of exp gain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Behaviour
Actual
When enable vip system with bonus exp, and you enable the XP_DISPLAY_MODE to true, the bonus is not show
Expected
When enable vip system with bonus exp, and you enable the XP_DISPLAY_MODE to true shows the complete amount of exp gain
Fixes #issuenumber
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Login and tests if the xp amount is shoing correctly.
] Test A
] Test B
Test Configuration: