fix: webhook race condition crash #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending webhooks there is a small chance that the webhooks.empty() if passes but when it gets the task the webhooks deque is already empty. That causes task to be a nullptr and accessing it causes a segmentation fault. There are two ways to solve if: place the lock in the beginning of the function or check if task exists before proceeding, we are adopting the first.
lgrossi
force-pushed
the
lucas/fix-webhook-crash-race-condition
branch
from
728e9ca to
a85b7e9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Aug 29, 2023
|
Signed off by @Sorairei |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1522
When sending webhooks there is a small chance that the webhooks.empty() if passes but when it gets the task the webhooks deque is already empty.
That causes task to be a nullptr and accessing it causes a segmentation fault.
There are two ways to solve if: place the lock in the beginning of the function or check if task exists before proceeding, we are adopting the first.