Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: items xml loading (wrong attributes) #1584

Merged
merged 1 commit into from
Sep 9, 2023
Merged

fix: items xml loading (wrong attributes) #1584

merged 1 commit into from
Sep 9, 2023

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented Sep 9, 2023

Fixed from: 6a7a19e

For use of 13.21 protocol: #1523

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 3255a63 into main Sep 9, 2023
@dudantas dudantas deleted the fix-items-xml branch September 9, 2023 16:02
dudantas referenced this pull request Sep 9, 2023
Adds primary type to items in items.xml. This is to enable 13.21 features such as filters in store inbox.
JasterDesu pushed a commit to JasterDesu/canary that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants