fix: questlog message #1648
Merged
fix: questlog message #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luan
approved these changes
Sep 29, 2023
majestyotbr
changed the title
majestyotbr
approved these changes
Sep 29, 2023
dudantas
approved these changes
Sep 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
luan
added a commit
that referenced
this pull request
Sep 30, 2023
…ripted-weapon-and-moveevent * upstream/main: (21 commits) improve: revision of codes in data/ (#1374) fix: questlog message (#1648) improve: ensure players are removed from zones on death (#1650) improve: zstream static (#1644) feat: adding training shield and exercise shields (#1607) feat: benchmark tools (#1649) improve: optimize house/kv saves (#1634) fix: wong prey race ids and trashholder items (#1643) fix: move store items only to house tile (#1642) fix: attr condition enums (subid foods and others) (#1641) docs: add TNT Cloud support (#1639) fix: house transfer owner only in startup (#1621) fix: transfer house item (#1633) fix: some getUserdataShared and transfer house (sell) (#1632) fix: ammotype sanguine crossbow (#1624) feat: update talkactions add_addons and add_mounts (#1612) feature: imbuements get slot items (#1628) fix: reward container add charges to the items on boss death (#1629) improve: convert NetworkMessage and Combat to shared_ptr (#1627) feat: config.lua option for enable/disable mount in protection zone (#1599) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Someone removed memorizing old storage value in addStorageValue, so playerOnStorageUpdate receives only new value. The condition "if value ~= oldValue then" in Player.updateStorage function is therefore always false, thus "Your questlog has been updated." message cannot be ever sent. It was this commit that broke it: #573
Behaviour
Actual
Changeing storage value associated with a mission doesnt show "Your questlog has been updated." message.
Expected
Changeing storage value associated with a mission does show "Your questlog has been updated." message.
Fixes #1102
Type of change
How Has This Been Tested
I talked to npc gerimor: hi -> missions -> life -> yes, any got the questlog updated message.
Test Configuration: