improve: review of everything using set

[mehah]

this PR aims to exchange for the best set or for another more viable collection.

when to use???

• std::set
  • Never!!! Only if the order is important
• std::unordered_set
  • It is the best option for any type of search, but with few moments of inserting and removing.
• phmap::flat_hash_set
  • On average, this is the best option if you are not going to do a linear search.
• vector_set
  • It seems like the best option, but it isn't. It's great if you're inserting elements in batches, because every time you insert them, a flag fires telling you that you need to do sort + unique and this happens if you do a search or a delete.
  • In short, it's perfect for keeping a set of unique information for a short period of time, for example within a method.

stdext::vector_set<int> unique_list;

std::vector<int> list1 { 1, 3, 4, 5 };
std::vector<int> list2 { 4, 2, 87, 2 };
std::vector<int> list3 { 3, 1, 99, 5 };
unique_list.insertAll(list1);
unique_list.insertAll(list2);
unique_list.insertAll(list3);

for (auto v : unique_list) {
	// print 1, 2, 3, 4, 5, 87, 99
}

Benchmark

const auto &benchmark = [](std::string_view imple, auto set) {
	constexpr auto stress = 99999999;

	Benchmark bm;
	for (size_t d = 0; d < stress; d++) {
		set.emplace((rand() % stress) + 1);
	}
	set.begin(); // Force Update vector_set
	g_logger().info("{} - emplace {}ms", imple, bm.duration());
	bm = {};
	for (size_t d = 0; d < 999999; d++) {
		for (const auto &v : set) { }
	}
	g_logger().info("{} - linear search {}ms", imple, bm.duration());
	bm = {};
	for (size_t d = 0; d < stress; d++) {
		set.contains((rand() % stress) + 1);
	}
	g_logger().info("{} - random search {}ms", imple, bm.duration());
	bm = {};
	for (size_t d = 0; d < stress; d++) {
		set.erase((rand() % stress) + 1);
	}
	g_logger().info("{} - random remove {}ms", imple, bm.duration());
};

benchmark("std::vector_set", stdext::vector_set<uint32_t>());
benchmark("std::set", std::set<uint32_t>());
benchmark("std::unordered_set", std::unordered_set<uint32_t>());
benchmark("phmap::flat_hash_set", phmap::flat_hash_set<uint32_t>());

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication