feat: update public and internal server versions #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luan
approved these changes
Oct 21, 2023
dudantas
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds descriptive comments to clarify the purpose and usage of the version constants STATUS_SERVER_VERSION and SERVER_RELEASE_VERSION.
The STATUS_SERVER_VERSION constant is intended for external displays, like server listings on otlist (otservlist.com), and only shows the major version. This helps to minimize frequent changes in otlist categories.
On the other hand, SERVER_RELEASE_VERSION is the full version of the Canary Server, intended for internal use. It helps in identifying the exact state of the server software.
Changes:
Added comments to STATUS_SERVER_VERSION explaining its usage for external displays, particularly on otlist.
Added comments to SERVER_RELEASE_VERSION explaining its purpose for internal use to identify the server's exact version.