Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solves the problem when combining zone pvp and no-logout tiles #2123

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fix: solves the problem when combining zone pvp and no-logout tiles #2123

merged 1 commit into from
Jan 27, 2024

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Jan 19, 2024 •
edited
Loading

fecha opentibiabr/remeres-map-editor#60 e #1765

Como informado no primeiro issue mencionado: quando existia a junção dos tiles zones de pvp e no-logout, o zone pvp não funcionava.

  • ❌ No-logout + pvp zone = no-logout funciona e pvp zone não.
  • ✅ No-logout + protection zone = os dois funcionam.
  • ✅ No-logout + no-pvp zone = os dois funcionam.

O problema estava na posição das condicionais em #557. Com este PR resolve o problema.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Schiffers
Schiffers reviewed Jan 20, 2024
View reviewed changes
Copy link
Contributor

@Schiffers Schiffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is working, tested trying logout in the zone, the result was the expected (cannot log)
pvp part working.

@dudantas dudantas added this pull request to the merge queue Jan 27, 2024
Merged via the queue into opentibiabr:main with commit bceaa24 Jan 27, 2024
26 checks passed
@dudantas dudantas deleted the fix-pvp-zone branch January 27, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schiffers Schiffers Schiffers left review comments

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luanluciano93 @dudantas @Schiffers