Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: livestream (cast) system #2653

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: livestream (cast) system #2653

wants to merge 43 commits into from

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented May 25, 2024 •
edited
Loading

Extensive testing and reviews are required to ensure the correct functioning of the system.

In my tests everything is working.

New login for 13x (won't work in Tibia 13 without this login)
login.zip

Works on

  • Tibia 11 outdated
  • Otclient
  • Tibia 13+

@dudantas dudantas force-pushed the dudantas/feat-casting-system branch 2 times, most recently from 55c9eb6 to 094c8fe Compare May 25, 2024 22:08
@mattyx14

This comment was marked as off-topic.

Sign in to view
phacUFPE

This comment was marked as outdated.

Sign in to view

phacUFPE

This comment was marked as outdated.

Sign in to view

@elsongabriel elsongabriel mentioned this pull request May 28, 2024
Open
@dudantas dudantas marked this pull request as draft May 28, 2024 23:02
@dudantas dudantas marked this pull request as ready for review May 28, 2024 23:05
@cys9211

This comment was marked as outdated.

Sign in to view
@elsongabriel elsongabriel force-pushed the dudantas/feat-casting-system branch from 0b3e4f6 to a90f6db Compare May 29, 2024 14:43
@elsongabriel

This comment was marked as resolved.

Sign in to view
@Chapeleiiro

This comment was marked as resolved.

Sign in to view
phacUFPE

This comment was marked as outdated.

Sign in to view

@OpenTibiaMX2

This comment has been minimized.

Sign in to view
1 similar comment
@OpenTibiaMX2

This comment has been minimized.

Sign in to view
@jbracovich

This comment was marked as resolved.

Sign in to view
@XmasGame

This comment was marked as off-topic.

Sign in to view
@XmasGame

This comment was marked as resolved.

Sign in to view
@XmasGame

This comment was marked as outdated.

Sign in to view
@Chapeleiiro

This comment was marked as resolved.

Sign in to view
@elsongabriel elsongabriel marked this pull request as draft June 12, 2024 13:42
@opentibiabr opentibiabr deleted a comment from luanluciano93 Jun 15, 2024
@dudantas

This comment was marked as outdated.

Sign in to view
jhogberg
jhogberg reviewed Jun 21, 2024
View reviewed changes
Copy link

@jhogberg jhogberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tibiacast author here, I was having a trip down memory lane when I stumbled on this PR. I figured I'd leave a review. 🙂

src/server/network/protocol/protocolgame.cpp Outdated Show resolved Hide resolved
src/server/network/protocol/protocolgame.cpp Outdated Show resolved Hide resolved
config.lua.dist Outdated Show resolved Hide resolved
src/creatures/players/cast/cast_viewer.cpp Outdated Show resolved Hide resolved
src/server/network/protocol/protocolgame.cpp Outdated Show resolved Hide resolved
src/creatures/players/cast/cast_viewer.cpp Outdated Show resolved Hide resolved
src/creatures/players/cast/cast_viewer.cpp Outdated Show resolved Hide resolved
src/creatures/players/cast/cast_viewer.cpp Outdated Show resolved Hide resolved
src/creatures/players/cast/cast_viewer.cpp Outdated Show resolved Hide resolved
src/creatures/players/cast/cast_viewer.cpp Outdated Show resolved Hide resolved
@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from 597662c to 95c4e72 Compare July 4, 2024 19:58
@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from 95c4e72 to 8e3f892 Compare July 4, 2024 22:02
@majestyotbr
Copy link
Contributor

majestyotbr commented Jul 10, 2024 •
edited
Loading

Update your pull request and use the pull request template.

@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from 1c4031e to 3d5f9b4 Compare September 23, 2024 17:12
@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from fa83978 to 688067f Compare September 24, 2024 03:00
@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from 06b24fc to a1a2bd1 Compare September 24, 2024 03:27
@TheLionEscanor
Copy link

Captura
This only happens with client 13.40 after a short moment of being a spectator, in OTClient it is stable

@dudantas
Copy link
Member Author

Captura This only happens with client 13.40 after a short moment of being a spectator, in OTClient it is stable

Please provide more details, because I haven't been able to find any problems yet and the debug log doesn't have the debug hash.

What were you doing at the time? Where were you? Did you perform any action? etc.

@TheLionEscanor
Copy link

Captura This only happens with client 13.40 after a short moment of being a spectator, in OTClient it is stable

Please provide more details, because I haven't been able to find any problems yet and the debug log doesn't have the debug hash.

What were you doing at the time? Where were you? Did you perform any action? etc.

It was a packet problem, for now it is stable, but now i cant enter to the livestream in OTClient, is just waiting for loading the livestreams table throwing this:
ERROR: Unknown data type 45
ERROR: Unknown data type 71
ERROR: protected lua call failed: /modules/corelib/inputmessage.lua:31: table index is nil
stack traceback:
[C]: in function '__newindex'
/modules/corelib/inputmessage.lua:31: in function 'getTable'
/modules/gamelib/protocollogin.lua:286: in function 'parseExtendedCharacterList'
/modules/gamelib/protocollogin.lua:183: in function </modules/gamelib/protocollogin.lua:163>

@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from 7abd1d8 to 8d5afaf Compare October 10, 2024 01:33
@opentibiabr opentibiabr deleted a comment from github-actions bot Oct 10, 2024
@dudantas dudantas force-pushed the dudantas/feat-casting-system branch from 88624fc to 361e877 Compare October 10, 2024 01:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OpenTibiaMX

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Nov 21, 2024
@Mattz0n
Copy link

Mattz0n commented Jan 11, 2025

Is this cast system working on Canary 1340 ? or is it outdated as it stays?

@github-actions github-actions bot removed the Stale No activity label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beats-dh beats-dh beats-dh left review comments

@jhogberg jhogberg jhogberg left review comments

@elsongabriel elsongabriel elsongabriel left review comments

@mehah mehah mehah left review comments

@phacUFPE phacUFPE phacUFPE requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.