Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sharpshooter not applying paralyze icon #3119

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

FelipePaluco
Copy link
Contributor

@FelipePaluco FelipePaluco commented Nov 15, 2024

Description

This commit aims to fix a problem that occurs when a player cast sharpshooter.
The main behavior should be remove haste icon and apply paralyze, counting with the speed decreasement.

(utito tempo san)

Behaviour

Actual

image

Expected

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Cast utito tempo san and see if the haste icon will dissapear. Paralyze icon should be displayed.
  • The speed should be decrease at 70%

Test Configuration:

  • Server Version: latest
  • Client: latest
  • Operating System: latest

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This commit aims to fix a problem that occurs when a player cast sharpshooter. 

The main behavior should be remove haste effect (and icon) and apply paralyze, counting with the speed decreasement.
@FelipePaluco FelipePaluco changed the title fix: sharpshooter not applying paralyze fix: sharpshooter not applying paralyze icon Nov 15, 2024
jprzimba added a commit to jprzimba/crystalserver that referenced this pull request Nov 16, 2024
@dudantas dudantas merged commit e0cee27 into main Nov 19, 2024
26 checks passed
@dudantas dudantas deleted the fix/paralyze-utito-tempo-san branch November 19, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants