perf: refactor imbuement decay to per-item management

[dudantas]

Description

This refactors the imbuement decay system, changing it from a player-wide loop to a per-item approach. This significantly optimizes performance by reducing redundant checks and focusing only on items that require decay updates. The refactor includes:

• Dynamic scheduling based on active imbuements.
• Handling decay conditions for protection zones, fight mode, and backpack rules directly on individual items.
• Improved scalability and maintainability of the code.

Resolves #3135

Behaviour

Actual

The previous implementation iterated through all players and their inventory items to process imbuement decay. This led to unnecessary overhead, even for players with no relevant items.

Expected

The new implementation tracks only items with active imbuements, dynamically managing their decay schedule and conditions. This minimizes unnecessary processing and ensures accurate decay handling.

Type of change

• Performance improvement (non-breaking change that improves efficiency)
• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

The changes were tested with the following scenarios:

• Test A: Items with imbuements were observed for accurate decay, ensuring decay stops or continues correctly based on conditions.
• Test B: Players in protection zones and fight mode were tested to ensure appropriate imbuement handling.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[lBaah]

Function stopImbuementDecay need to check if it can decay imbuement duration before doing it, otherwise it will decay the imbuement time when you unequip an item from the inventory, no matter if it can or not decay, based on the elapsed time. For example, it decays when in protection zones.

[dudantas]

Function stopImbuementDecay need to check if it can decay imbuement duration before doing it, otherwise it will decay the imbuement time when you unequip an item from the inventory, no matter if it can or not decay, based on the elapsed time. For example, it decays when in protection zones.

I didn't understand your comment. Have you tested it? This check has already been done.