Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent teleportation #3143

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

omarcopires
Copy link
Contributor

Description

This PR fixes an issue where the player was teleported even when a Lua script was blocking the action. Additionally, the code has been refactored to optimize the handling of magic effects, eliminating redundancies and improving readability. The logic for checking and applying the magic effect has been consolidated, making the code more efficient.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas merged commit 6253d64 into opentibiabr:main Nov 21, 2024
24 checks passed
@dudantas dudantas changed the title fix: prevent teleportation and refactor magic effect handling fix: prevent teleportation Nov 21, 2024
@omarcopires omarcopires deleted the fix-teleport branch November 21, 2024 19:11
@TheLionEscanor
Copy link

Im not sure, but i think with this PR now when using stairs it shows a teleportation effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants