Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rate player attack #3170

Closed
wants to merge 2 commits into from

Conversation

omarcopires
Copy link
Contributor

Description

This implementation introduces a global damage multiplier for all players. The multiplier is retrieved dynamically from the configuration RATE_PLAYER_ATTACK using g_configManager().getFloat() and is applied to the primary and secondary damage values. This allows adjusting the overall attack strength of players through configuration without modifying the core logic. Additionally, the base damage and the scaled damage are logged for debugging purposes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarqubecloud bot commented Dec 5, 2024

@omarcopires omarcopires closed this Dec 6, 2024
@omarcopires omarcopires deleted the rate-player-attack branch December 6, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant