Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing constants for client OS #3179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

omarcopires
Copy link
Contributor

Description

Add missing constants for client OS handling

Example:

local allowedOS = {
	[CLIENTOS_NONE] = false,
	[CLIENTOS_LINUX] = true,
	[CLIENTOS_WINDOWS] = true,
	[CLIENTOS_FLASH] = false,
	[CLIENTOS_NEW_LINUX] = true,
	[CLIENTOS_NEW_WINDOWS] = true,
	[CLIENTOS_NEW_MAC] = true,
	[CLIENTOS_OTCLIENT_LINUX] = false,
	[CLIENTOS_OTCLIENT_WINDOWS] = false,
	[CLIENTOS_OTCLIENT_MAC] = false,
	[CLIENTOS_OTCLIENTV8_LINUX] = false,
	[CLIENTOS_OTCLIENTV8_WINDOWS] = false,
	[CLIENTOS_OTCLIENTV8_MAC] = false,
	[CLIENTOS_OTCLIENTV8_ANDROID] = false,
	[CLIENTOS_OTCLIENTV8_IOS] = false,
	[CLIENTOS_OTCLIENTV8_WEB] = false,
}

local blockUnofficialClients = CreatureEvent("BlockUnofficialClients")

function blockUnofficialClients.onLogin(player)
	local clientInfo = player:getClient()
	if not clientInfo or not allowedOS[clientInfo.os] then
		local osName = clientInfo and clientInfo.os or "Unknown OS"
		local clientVersion = clientInfo and clientInfo.version or "Unknown version"

		logger.info("[blockUnofficialClients.onLogin] Player attempted login with OS: {}, Version: {}", osName, clientVersion)
		return false
	end

	return true
end

blockUnofficialClients:register()

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant