Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grand master oberon immunity and butterfly's raceid #3307

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

Jonyrewind
Copy link
Contributor

It was setting him immune on the start immunity is already handled in his monster file.

Butterfly's had the wrong raceId's and and the Bestiary Kills weren't assigned properly.

It was setting him immune on the start immunity is already handled in his monster file.

Butterfly's had the wrong raceId's and and the Bestiary Kills weren't assigned properly.
@FelipePaluco
Copy link
Contributor

Do you tested the whole of oberon? It's ok? the phrases mechanic, immunity and the normal mode?

@Jonyrewind
Copy link
Contributor Author

Do you tested the whole of oberon? It's ok? the phrases mechanic, immunity and the normal mode?

yeah on my server it works with replies and the immunity.

@FelipePaluco
Copy link
Contributor

FelipePaluco commented Jan 29, 2025

@Jonyrewind Thanks, a recent PR have bugged several quests, i'm trying or best to revert ASAP. Thanks for the contribution.

We were looking into this case, but it looks like you were quicker.

By chance, can you can take a look into Scarlet Etzel using canary/main latest?

@majestyotbr majestyotbr changed the title fix: Grand Master Oberon Immunity and Butterfly's raceId fix: grand master oberon immunity and butterfly's raceid Jan 29, 2025
@majestyotbr
Copy link
Contributor

You need to remove the monster event "oberonImmune" from the grand master oberon.

@fugu320
Copy link

fugu320 commented Jan 29, 2025

There are also some problems with onSpawn in Oberon, for example:

mType.onSpawn = function(monster)
monster:setStorageValue(GrandMasterOberonConfig.Storage.Asking, 0)
monster:setStorageValue(GrandMasterOberonConfig.Storage.Life, 1)
end
It doesn't load at all, and when checking, logger.info starts with storage.life at -1.

@majestyotbr majestyotbr linked an issue Feb 1, 2025 that may be closed by this pull request
5 tasks
@majestyotbr majestyotbr merged commit 3046566 into opentibiabr:main Feb 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grand Master Oberon Immunity
4 participants