Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest-log-review #3415

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Quest-log-review #3415

wants to merge 11 commits into from

Conversation

htc16
Copy link
Contributor

@htc16 htc16 commented Mar 2, 2025

Description

My purpose is to review the existing quest log, trying to fix as many flaws as possible that prevent it from functioning and fulfilling its purpose.

Feel free to help me by choosing a quest and reviewing it yourself.

I may not be able to be as quick this time, but my purpose is to go slowly since there are not many reviews to be done.

  • The Queen of the Banshees
  • The Paradox Tower
  • Spike Task
  • A Father's Burden
  • Bigfoot's Burden
  • Children of the Revolution
  • Factions
  • Friends and Traders
  • Hot Cuisine
  • In Service of Yalahar
  • Killing in the Name of...
  • Outfit and Addon Quests
  • Sam's Old Backpack
  • Sea of Light
  • Secret Service
  • The Ancient Tombs
  • The Ape City
  • The Beginning
  • The Djinn War - Efreet Faction
  • The Djinn War - Marid Faction
  • The Hidden City of Beregar
  • The Ice Islands Quest
  • The Inquisition
  • The Postman Missions
  • The Shattered Isles
  • The Thieves Guild
  • The Travelling Trader Quest
  • The Explorer Society
  • The Ultimate Challenges
  • The White Raven Monastery
  • Tibia Tales
  • Unnatural Selection
  • What a foolish Quest
  • Wrath of the Emperor
  • Oramond
  • Forgotten Knowledge
  • The First Dragon
  • Cults of Tibia
  • Dangerous Depths
  • Adventurers Guild
  • Dawnport
  • The Rookie Guard
  • The New Frontier
  • Spirithunters Quest
  • Threatened Dreams
  • Blood Brothers
  • Grave Danger
  • The Outlaw Camp
  • The Secret Library
  • The Dream Courts

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@htc16 htc16 marked this pull request as draft March 2, 2025 14:19
htc16 and others added 7 commits March 2, 2025 14:58
In the case of "killing in the name of" it is impossible to check it at this time. The right thing to do in this case is to pick it up and check it once and see if everything is working correctly due to its size.
@htc16 htc16 marked this pull request as ready for review March 6, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant