Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Item name register from appearances protobuf #376

Merged
merged 1 commit into from
May 4, 2022
Merged

[Fix] Item name register from appearances protobuf #376

merged 1 commit into from
May 4, 2022

Conversation

marcosvf132
Copy link
Contributor

@marcosvf132 marcosvf132 commented May 4, 2022 •
edited
Loading

Description

It was missing the item name register on the function void Items::loadFromProtobuf() on the Items map. This map is used to identify a item by it's name instead of ID. This is largely used on the SRC and LUA environments.

This wrong behavior on the items name register was affecting only items who had their names on the appearances.dat protobuf file but was not registered on the items.xml file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  1. On the actual SRC (Without this PR), go to the items.xml file.
  2. Remove the entire register from any item that have it's name registered on the appearances.dat. (Try the fire sword only for tests)
  3. Run the server and try to /i fire sword and see that the server is unable to identify and create the item by it's name.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@marcosvf132 marcosvf132 requested a review from beats-dh May 4, 2022 03:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

beats-dh
beats-dh approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@beats-dh beats-dh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly

@marcosvf132 marcosvf132 merged commit a4073d7 into opentibiabr:main May 4, 2022
@marcosvf132 marcosvf132 deleted the fix-item-register-name branch May 4, 2022 19:21
luan pushed a commit that referenced this pull request Jul 11, 2023
@marcosvf132
[Fix] Item name register from appearances protobuf #376
63f6adb 
It was missing the item name register on the function void Items::loadFromProtobuf() on the Items map. This map is used to identify a item by it's name instead of ID. This is largely used on the SRC and LUA environments.

This wrong behavior on the items name register was affecting only items who had their names on the appearances.dat protobuf file but was not registered on the items.xml file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@omeranha omeranha omeranha approved these changes

@beats-dh beats-dh beats-dh approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcosvf132 @dudantas @omeranha @beats-dh