[Bug] fixes some prey and taskhunting fixes #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
added
Status: Pending Review
dudantas
commented
Nov 29, 2022
dudantas
changed the title
dudantas
commented
Dec 3, 2022
murilo09
approved these changes
Dec 5, 2022
omeranha
approved these changes
Dec 5, 2022
beats-dh
approved these changes
Dec 8, 2022
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
dudantas
changed the title
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
• Tasks hunting kill fix: If the player is at a party and with experience sharing enabled and active, it will kill everyone who damages the monster Font: https://www.tibiaqa.com/17999/how-are-prey-hunting-task-creatures-counted • Task hunting buy slot on store fix: Reorganized the order of offers by ID and added the possibility to buy the hunting tasks slot Fixed in "init.lua" the redirection of the offers IDs of the third slot of the hunting task and prey Added OFFER_TYPE_HUNTINGSLOT enum to GameStore.OfferTypes Fixed for the second slot to be active for premium accounts only • Prey fixes: Fixed the loot prey, it was giving the percentage of chance more to drop the items, the correct thing is to just give the percentage of chance of dropping all the loot again. For example, if the player kills a demon and drops 1 demon armor and 1 demon helmet, with the preyloot active there will be a percentage chance (defined by the prey) of dropping the loot again. As if the monster dropped loot twice in a row. Fixed for the second slot to be active for premium accounts only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tasks hunting kill fix:
If the player is at a party and with experience sharing enabled and active, it will kill everyone who damages the monster
Font: https://www.tibiaqa.com/17999/how-are-prey-hunting-task-creatures-counted
Task hunting buy slot on store fix:
Reorganized the order of offers by id and added the possibility to buy the hunting tasks slot
Fixed in init.lua the redirection of the offers ids of the third slot of the hunting task and prey
Added OFFER_TYPE_HUNTINGSLOT enum to GameStore.OfferTypes
Fixed for the second slot to be active for premium accounts only
Prey fixes:
Fixed the loot prey, it was giving the percentage of chance more to drop the items, the correct thing is to just give the percentage of chance of dropping all the loot again. For example, if the player kills a demon and drops 1 demon armor and 1 demon helmet, with the preyloot active there will be a percentage chance (defined by the prey) of dropping the loot again. As if the monster dropped loot twice in a row.
Fixed for the second slot to be active for premium accounts only
Type of change
How Has This Been Tested
Enter the party and activate experience sharing, everyone who attacks the monster will receive a kill in hunting tasks.
If the party is not activated, only the last hit will receive the kill.
Test Configuration:
Checklist