enhance: remove boost-variant #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Costallat
approved these changes
Dec 29, 2022
beats-dh
approved these changes
Dec 29, 2022
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
added a commit
that referenced
this pull request
Dec 30, 2022
dudantas
added a commit
to dudantas/canary
that referenced
this pull request
Feb 7, 2023
Removal of boost::variant and derivatives, reducing the amount of libs the project needs to compile. A rework was performed on the "struct CustomAttribute", to remove the generic types that were used in boost::variant, which could also cause an increase in memory usage.
dudantas
added a commit
to dudantas/canary
that referenced
this pull request
Feb 7, 2023
Complement of commit: opentibiabr@d241481 PR: opentibiabr#722
jacksonie
pushed a commit
to jacksonie/canary
that referenced
this pull request
Feb 17, 2023
Removal of boost::variant and derivatives, reducing the amount of libs the project needs to compile. A rework was performed on the "struct CustomAttribute", to remove the generic types that were used in boost::variant, which could also cause an increase in memory usage.
jacksonie
pushed a commit
to jacksonie/canary
that referenced
this pull request
Feb 17, 2023
Complement of commit: opentibiabr@d241481 PR: opentibiabr#722
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Removal of boost::variant and derivatives, reducing the amount of libs the project needs to compile. A rework was performed on the "struct CustomAttribute", to remove the generic types that were used in boost::variant, which could also cause an increase in memory usage.
dudantas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removal of boost::variant and derivatives, reducing the amount of libs the project needs to compile.
A rework was performed on the "struct CustomAttribute", to remove the generic types that were used in boost::variant, which could also cause an increase in memory usage.