fix: item not decaying duration and related bugs #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udantas/canary into fix-not-decaying-item-duration
…udantas/canary into fix-not-decaying-item-duration
|
SonarCloud Quality Gate failed. |
dudantas
changed the title
5 tasks
beats-dh
pushed a commit
to beats-dh/canary
that referenced
this pull request
Feb 26, 2023
• Fixed item decay with duration (both equip/deEquip and onUse), • Fixed the look of items with duration, it did not show the duration of some items (example rings, when equipped), • Functions created in the Item class to avoid code duplication and facilitate the maintenance readability of some systems • Removed old code from imbuement, which is no longer used • Removed the decay of items created by loading the ".otbm" map from decay std::map, thus decreasing by about three thousand five hundred items in the decay check.
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
• Fixed item decay with duration (both equip/deEquip and onUse), • Fixed the look of items with duration, it did not show the duration of some items (example rings, when equipped), • Functions created in the Item class to avoid code duplication and facilitate the maintenance readability of some systems • Removed old code from imbuement, which is no longer used • Removed the decay of items created by loading the ".otbm" map from decay std::map, thus decreasing by about three thousand five hundred items in the decay check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
• Fixed item decay with duration (both equip/deEquip and onUse),
• Fixed the look of items with duration, it did not show the duration of some items (eg rings, when equipped),
• Functions created in the Item class to avoid code duplication and facilitate the maintenance readability of some systems
• Removed old code from imbuement, which is no longer used
• Removed the decay of items created by loading the .otbm from decay map, thus decreasing by about three thousand five hundred items in the decay check.
Behaviour
Actual
Systems mentioned in the description did not work correctly.
Expected
Everything working perfectly.
Type of change
How Has This Been Tested
Basically test the decay of the duration of items and also the decay of items for other ids.