-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enables opening monster corpse post-reward collection #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachieDude
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as made at least in data-canary.. i wont set as approved cuz i didnt test on data-otservbr-global
Kudos, SonarCloud Quality Gate passed! |
majestyotbr
approved these changes
Mar 5, 2023
dudantas
approved these changes
Mar 6, 2023
5 tasks
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
• Allows players to open monster corpse even if they have already claimed their reward: Improvement to the game functionality, allowing players to open a monster corpse even after they have claimed their reward for defeating it. Currently, once the reward is collected, the monster corpse cannot be opened any more, which can be frustrating for players who want to collect additional items or complete quests. With this update, players will be able to open the monster corpse at any time, regardless of whether they have already received the reward, providing a more satisfying and flexible experience for players.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: allows players to open monster corpse even if they have already claimed their reward
Improvement to the game functionality, allowing players to open a monster corpse even after they have claimed their reward for defeating it. Currently, once the reward is collected, the monster corpse cannot be opened any more, which can be frustrating for players who want to collect additional items or complete quests. With this update, players will be able to open the monster corpse at any time, regardless of whether they have already received the reward, providing a more satisfying and flexible experience for players.
Behaviour
Actual
The game is returning a message that you aren't the owner if you already collected the boss reward
Expected
The game should let the corpse be opened and warn that the reward was already claimed
Type of change