Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enables opening monster corpse post-reward collection #885

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

ElimarCosta
Copy link
Contributor

@ElimarCosta ElimarCosta commented Feb 24, 2023

Description

fix: allows players to open monster corpse even if they have already claimed their reward

Improvement to the game functionality, allowing players to open a monster corpse even after they have claimed their reward for defeating it. Currently, once the reward is collected, the monster corpse cannot be opened any more, which can be frustrating for players who want to collect additional items or complete quests. With this update, players will be able to open the monster corpse at any time, regardless of whether they have already received the reward, providing a more satisfying and flexible experience for players.

Behaviour

Actual

The game is returning a message that you aren't the owner if you already collected the boss reward

Expected

The game should let the corpse be opened and warn that the reward was already claimed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@ElimarCosta ElimarCosta changed the title fix reward boss corpse fix: reward boss corpse Feb 24, 2023
Copy link
Contributor

@PeachieDude PeachieDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as made at least in data-canary.. i wont set as approved cuz i didnt test on data-otservbr-global

@ElimarCosta ElimarCosta marked this pull request as ready for review February 24, 2023 19:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas changed the title fix: reward boss corpse fix: enables opening monster corpse post-reward collection Mar 6, 2023
@dudantas dudantas merged commit 1fbece0 into opentibiabr:main Mar 6, 2023
@ElimarCosta ElimarCosta deleted the fix-reward-boss branch March 16, 2023 22:24
luan pushed a commit that referenced this pull request Jul 11, 2023
• Allows players to open monster corpse even if they have already claimed their reward:
Improvement to the game functionality, allowing players to open a monster corpse even after they have claimed their reward for defeating it. Currently, once the reward is collected, the monster corpse cannot be opened any more, which can be frustrating for players who want to collect additional items or complete quests. With this update, players will be able to open the monster corpse at any time, regardless of whether they have already received the reward, providing a more satisfying and flexible experience for players.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants