Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: small improvements and fixes #919

Merged
merged 28 commits into from
Mar 28, 2023
Merged

improve: small improvements and fixes #919

merged 28 commits into from
Mar 28, 2023

Conversation

elsongabriel
Copy link
Contributor

@elsongabriel elsongabriel commented Mar 11, 2023 •
edited
Loading

Description

  • Small adjustments in code, as best practices in variables, and indentation;
  • Created toggles:
    • Make gold pouch configurable to put items in it other than gold;
    • Set server retro pvp (disabling PARTY_PROTECTION and ADVANCED_SECURE_MODE in globa.lua);
    • Make all travel free;
  • Set level 10 to use softboots, were level 180;
  • Improved testserver_assistant.lua;
  • Some TYPO corrections;
  • Improved talkaction online.lua;
  • Adjusted containersize of gold pouch to 20;
  • Improved recompile.sh;
  • Other small fixes;
  • Created bestiary and bosstiary multiplies factor in config.lua;
  • Created a config to multiplier forge dust received, and created notes of forge system;

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Test Configuration:

  • Server Version: Canary 2.6.1
  • Client: 12.91
  • Operating System: Ubuntu Server 22.04

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel elsongabriel marked this pull request as draft March 12, 2023 14:48
murilo09
murilo09 requested changes Mar 13, 2023
View reviewed changes
@elsongabriel elsongabriel force-pushed the fix/small-adjustments branch from 6089e90 to c55f051 Compare March 13, 2023 17:21
@elsongabriel elsongabriel requested review from mattyx14 and murilo09 and removed request for mattyx14 and murilo09 March 13, 2023 18:21
@elsongabriel elsongabriel marked this pull request as ready for review March 13, 2023 18:54
@murilo09 murilo09 changed the title feature: small improvements and fixes improve: small improvements and fixes Mar 14, 2023
@murilo09 murilo09 marked this pull request as draft March 14, 2023 01:48
murilo09
murilo09 reviewed Mar 14, 2023
View reviewed changes
@elsongabriel elsongabriel marked this pull request as ready for review March 17, 2023 05:00
@elsongabriel elsongabriel force-pushed the fix/small-adjustments branch from a0097ca to 999641f Compare March 22, 2023 15:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit abc70c1 into opentibiabr:main Mar 28, 2023
luan pushed a commit that referenced this pull request Jul 11, 2023
@elsongabriel
improve: small improvements and fixes (details in description) (#919)
a52140f 
• Small adjustments in code, as best practices in variables, and indentation;
• Created toggles:
  - Make gold pouch configurable to put items in it other than gold;
  - Set server retro pvp (disabling PARTY_PROTECTION and ADVANCED_SECURE_MODE in globa.lua);
  - Make all travel free;
• Set level 10 to use softboots, were level 180;
• Improved testserver_assistant.lua;
• Some TYPO corrections;
• Improved talkaction online.lua;
• Adjusted containersize of gold pouch to 20;
• Improved recompile.sh;
• Other small fixes;
• Created bestiary and bosstiary multiplies factor in config.lua;
• Created a config to multiplier forge dust received, and created notes of forge system;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattyx14 mattyx14 mattyx14 approved these changes

@dudantas dudantas dudantas approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@murilo09 murilo09 murilo09 approved these changes

Assignees
No one assigned
Labels
Area: Datapack Canary Area: Datapack Core Area: Datapack Global Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elsongabriel @mattyx14 @dudantas @majestyotbr @murilo09