improve: boss cooldown timer #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duuh30
changed the title
duuh30
changed the title
duuh30
changed the title
duuh30
changed the title
majestyotbr
changed the title
LeoBorges18
approved these changes
Mar 29, 2023
1 task
murilo09
approved these changes
Mar 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
majestyotbr
approved these changes
Mar 31, 2023
dudantas
approved these changes
Mar 31, 2023
Closed
5 tasks
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Creating a new function to use in Lua to update Boss Cooldown in the Client. If you use the mechanism created for the Lever() class, it takes care of this process automatically. Example: When killing the boss Duke Krule automatically, the Cooldown timer will be updated. But if you kill Boss Grand Master Oberon, he won't upgrade. This happens because the Oberon Lever update is done manually Note: For manual cases like above example. Oberon it is necessary to use the player:sendBosstiaryCooldownTimer() function after doing setStorageValue in the key timer of the boss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a new function to use in lua to update Boss Cooldown in the Client.
If you use the mechanism created for the Lever() class it takes care of this process automatically.
EXAMPLE
When killing the boss Duke Krule automatically the Cooldown timer will be updated. But if you kill Boss Grand Master Oberon he won't upgrade. This happens because the Oberon Lever update is done manuallyNOTE
For manual cases like above example. OBERON it is necessary to use the player:sendBosstiaryCooldownTimer() function after doing setStorageValue in the KEY Timer of the Boss.Behaviour
When this task is completed, the expected operation is when accessing the boss's room the Cooldown of that boss appears in the client without having to relog.
Actual
It only shows boss cooldowns on login.
If you access the boss X room, it does not update.
Expected
When this task is completed it is expected to update the client's boss cooldown whenever accessing a boss room.
Type of change
Please delete options that are not relevant.
How Has This Been Tested
To test if the change really works. I used the bosstiary_kill.lua file and added the created function player:sendBoostiaryCooldownTimer() on line 17.
When killing a new boss it is updated in the Bosse Cooldown tab.
Test Configuration:
Checklist