Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

[Compatibility/Enhancement] Rework on fluids colors and new monster race type (INK) #544

Merged
merged 8 commits into from
Apr 25, 2022

Conversation

marcosvf132
Copy link
Collaborator

@marcosvf132 marcosvf132 commented Apr 19, 2022

Description

  • Full rework on the way that the server handles the fluids, to use one single ENUM and remove all the garbage functions and maps that used to store the same values for fluids over and over again.
  • Add new creature race type named INK. This new race type is used mostly on creatures on the tibia "The Secret Library". Attacking those creatures or slain then will now create the proper type of blood pool/splash.

Issues

Resolves #299

Sync

This PR only will work when using with Canary opentibiabr/canary#324 changes.

@github-actions github-actions bot added the data label Apr 19, 2022
@marcosvf132 marcosvf132 added Type: Enhancement New feature or request Priority: Low Minor impact Type: Missing Content Content that was not yet implemented or is not following the accepted standards Area: Datapack data and removed data labels Apr 19, 2022
@marcosvf132 marcosvf132 changed the title [Enhancement] Rework on fluids colors + new monster race type (INK) [Sync] Rework on fluids colors + new monster race type (INK) Apr 19, 2022
Copy link
Contributor

@guispiller guispiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fix on npcs that sells fluids

@marcosvf132 marcosvf132 requested a review from guispiller April 25, 2022 19:35
dudantas pushed a commit to opentibiabr/canary that referenced this pull request Apr 25, 2022
…#324)

Description
Full rework on the way that the server handles the fluids, to use one single ENUM and remove all the garbage functions and maps that used to store the same values for fluids over and over again.
Add new creature race type named INK. This new race type is used mostly on creatures on the tibia "The Secret Library". Attacking those creatures or slain then will now create the proper type of blood pool/splash.

Resolves #123

OTServerBr-Global PR: opentibiabr/otservbr-global#544
@dudantas dudantas changed the title [Sync] Rework on fluids colors + new monster race type (INK) [Compatibility/Enhancement] Rework on fluids colors and new monster race type (INK) Apr 25, 2022
@dudantas dudantas merged commit 87e53b9 into opentibiabr:main Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Datapack Priority: Low Minor impact Type: Enhancement New feature or request Type: Missing Content Content that was not yet implemented or is not following the accepted standards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Splash Type - Black Blood (Ink)
5 participants