Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix the new frontier quest #781

Merged
merged 24 commits into from
Sep 30, 2022
Merged

Fix the new frontier quest #781

merged 24 commits into from
Sep 30, 2022

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Sep 7, 2022 •
edited
Loading

Description

Rework The New Frontier Quest - Mission 05, based on Mission 05. Some NPCs transcriptions are wrong.

Remove conflicting AID in The New Frontier Quest (Mission 09) with Custom Map.

And a small fix in how Mortal Kombat Lever handle the players trying to enter.

Remove AID and UID from Positions:

  • 33004, 31540, 0
  • 33005, 31540, 0
  • 33021, 31536, 4
  • 33021, 31536, 6
  • 33053, 31020, 7
  • 33345, 31116, 7
  • 33165, 31249, 11
  • 33170, 31248, 11

These AID were not previously removed

  • 32515, 31927, 7
  • 32474, 31947, 7
  • 32458, 31997, 7

Behaviour

Actual

Conflicting AID with Custom Map

Fixes

This issues was reported on Discord

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@majestyotbr majestyotbr changed the title Conflicting AID with Custom Map Fix the new frontier quest action id conflict with custom map Sep 7, 2022
@majestyotbr majestyotbr changed the title Fix the new frontier quest action id conflict with custom map Fix the new frontier quest action id conflict with custom map and mortal kombat lever Sep 7, 2022
@majestyotbr majestyotbr changed the title Fix the new frontier quest action id conflict with custom map and mortal kombat lever Fix the new frontier quest action id conflict with custom map and the new frontier arena lever Sep 7, 2022
majestyotbr
majestyotbr suggested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@majestyotbr majestyotbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to migrate the quest to position and remove the actionid from the startup tables.

@majestyotbr majestyotbr marked this pull request as draft September 8, 2022 12:00
@majestyotbr majestyotbr marked this pull request as ready for review September 11, 2022 00:04
@majestyotbr majestyotbr marked this pull request as draft September 11, 2022 00:12
@majestyotbr majestyotbr marked this pull request as ready for review September 19, 2022 23:36
dudantas
dudantas suggested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the indentation back to tab.

@murilo09 murilo09 requested a review from dudantas September 21, 2022 03:53
@majestyotbr majestyotbr changed the title Fix the new frontier quest action id conflict with custom map and the new frontier arena lever Fix the new frontier quest Sep 30, 2022
@majestyotbr majestyotbr merged commit 23cdff9 into opentibiabr:main Sep 30, 2022
@murilo09 murilo09 deleted the fix-the-new-frontier-quest branch October 10, 2022 14:30
@murilo09 murilo09 mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@majestyotbr majestyotbr majestyotbr approved these changes

@dudantas dudantas Awaiting requested review from dudantas

Assignees
No one assigned
Labels
Area: Datapack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murilo09 @dudantas @majestyotbr