Skip to content

fix(renderless/input): [input] fix value become empty when the input type changed #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix(renderless/input): [input] fix value become empty when the input type changed #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6393b
fix(renderless/input): [input] fix value become empty when the input …
yoyo201626 Dec 5, 2023
9b8d7c8
Merge branch 'dev' of github.com:opentiny/tiny-vue into fix/input-typ…
yoyo201626 Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/renderless/src/input/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@
*
*/

import type { IInputApi, IInputClassPrefixConstants, IInputRenderlessParams, IInputState } from 'types/input.type'
import type {
IInputApi,
IInputClassPrefixConstants,
IInputRenderlessParamUtils,
IInputRenderlessParams,
IInputState
} from 'types/input.type'

const HIDDEN_STYLE = `
height:0 !important;visibility:hidden !important;overflow:hidden !important;
Expand Down Expand Up @@ -162,8 +168,8 @@ export const calcTextareaHeight =
return textareaStyle
}

export const getInput = (refs: IInputRenderlessParams['refs']) => (): HTMLTextAreaElement | HTMLInputElement =>
refs.input || refs.textarea
export const getInput = (vm: IInputRenderlessParamUtils['vm']) => (): HTMLTextAreaElement | HTMLInputElement =>
vm.$refs.input || vm.$refs.textarea

export const blur = (api: IInputApi) => (): void => api.getInput().blur()

Expand Down
11 changes: 7 additions & 4 deletions packages/renderless/src/input/vue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,14 @@ const initApi = ({
dispatch,
broadcast,
emit,
refs,
vm,
props,
CLASS_PREFIX,
parent
}: Pick<IInputRenderlessParams, 'api' | 'state' | 'dispatch' | 'broadcast' | 'emit' | 'refs' | 'props' | 'parent'> & {
}: Pick<
IInputRenderlessParams,
'api' | 'state' | 'dispatch' | 'broadcast' | 'emit' | 'refs' | 'props' | 'parent' | 'vm'
> & {
CLASS_PREFIX: IInputClassPrefixConstants
}) => {
Object.assign(api, {
Expand All @@ -174,7 +177,7 @@ const initApi = ({
broadcast,
showBox: showBox(state),
clear: clear(emit),
getInput: getInput(refs),
getInput: getInput(vm),
handleChange: handleChange(emit),
watchFormSelect: watchFormSelect({ emit, props, state }),
calcIconOffset: calcIconOffset({ CLASS_PREFIX, parent }),
Expand Down Expand Up @@ -327,7 +330,7 @@ export const renderless = (
}
const state = initState({ reactive, computed, mode, props, parent, constants, api })

initApi({ api, state, dispatch, broadcast, emit, refs, props, CLASS_PREFIX, parent })
initApi({ api, state, dispatch, broadcast, emit, refs, props, CLASS_PREFIX, parent, vm })

const storages = useStorageBox({ api, props, reactive, toRefs })

Expand Down