Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(numeric): [numeric] Fix Bug caused by initial value greater than maximum #1284

Merged
merged 3 commits into from
Feb 2, 2024
Merged

fix(numeric): [numeric] Fix Bug caused by initial value greater than maximum #1284

merged 3 commits into from
Feb 2, 2024

Conversation

wkif
Copy link
Contributor

@wkif wkif commented Jan 10, 2024 •
edited
Loading

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@wkif wkif changed the title Wkif/fix numeric bug fix(numeric): Fix Bug caused by initial value greater than maximum Jan 10, 2024
@kagol kagol added the bug Something isn't working label Jan 10, 2024
@AcWrong02
Copy link
Collaborator

你运行一下pnpm run test:unit3 numeric，单元测试好像没有通过

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.

If you run npm run test:unit 3 numeric, the unit test seems to have failed.

@wkif wkif force-pushed the wkif/fix-Numeric-bug branch from 8c3be47 to d63ac03 Compare January 11, 2024 07:23
@wkif
Copy link
Contributor Author

wkif commented Jan 11, 2024

你运行一下pnpm run test:unit3 numeric，单元测试好像没有通过

是滴，更新了测试文件，其中一个问题是另一个bug的了 964

@AcWrong02
Copy link
Collaborator

你运行一下pnpm run test:unit3 numeric，单元测试好像没有通过

是滴，更新了测试文件，其中一个问题是另一个bug的了 964

嗯嗯

@kagol kagol changed the title fix(numeric): Fix Bug caused by initial value greater than maximum fix(numeric): [numeric] Fix Bug caused by initial value greater than maximum Jan 16, 2024
@kagol kagol merged commit 34e5916 into opentiny:dev Feb 2, 2024
6 checks passed
fanbingbing16 pushed a commit to fanbingbing16/tiny-vue that referenced this pull request Feb 13, 2024
@wkif @fanbingbing16
fix(numeric): [numeric] Fix Bug caused by initial value greater than …
932793a 
…maximum (opentiny#1284)

* fix(numeric): Fix Bug caused by initial value greater than maximum

* fix(numeric): Fix Bug caused by initial value greater than maximum

* fix(numeric): Fix Bug caused by initial value greater than maximum
@Issues-translate-bot Issues-translate-bot mentioned this pull request Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AcWrong02 AcWrong02 AcWrong02 approved these changes

@kagol kagol kagol approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkif @AcWrong02 @Issues-translate-bot @kagol