fix(timeline): [time-line] fix console error about event click undefined
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gweesin
changed the title
event click undefined
kagol
changed the title
event click undefinedevent click undefined
kagol
changed the title
event click undefinedevent click undefined
Huangyilin19
approved these changes
Jan 31, 2024
fanbingbing16
pushed a commit
to fanbingbing16/tiny-vue
that referenced
this pull request
Feb 13, 2024
…ined` (opentiny#1297) * style(timeline): fix eslint validation errors * fix(timeline): fix console error about `event click undefined`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
using the Timeline component will cause Vue@2.6.14 runtime error
Issue Number: #1197
What is the new behavior?
The Timeline component could work seamlessly on both Vue 2 and Vue 3.
Does this PR introduce a breaking change?
Other information
The main issue is that the
contentClickfunction is referenced in thepc.vuetemplate without being defined there.Vue 3, however, addresses this by transforming the code to
onClick: _cache[0] || (_cache[0] = (...args) => _ctx.contentClick && _ctx.contentClick(...args)), ensuring the runtime executes successfully. In this setup, if_ctx.contentClickis undefined, it simply runs an empty function once.On the other hand, Vue 2 translates it to
on: {"click": _vm.contentClick"}, so if_vm.contentClickis undefined, an error occurs.