Skip to content

fix(loading): [icon] Fix loadingshadow, built-in rotation #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

chenxi-20
Copy link
Collaborator

@chenxi-20 chenxi-20 commented Aug 31, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Simplified loading indicators by removing complex animations, enhancing performance and reducing visual clutter.
  • Bug Fixes

    • Adjusted the animation duration for SVG elements, resulting in a slower and smoother visual effect.

@chenxi-20 chenxi-20 added the enhancement New feature or request (功能增强) label Aug 31, 2024
Copy link

coderabbitai bot commented Aug 31, 2024

Walkthrough

The changes involve adjustments to CSS properties in the theme package, specifically within the loading and autocomplete components. The .circular and .path classes, along with their associated animations, have been completely removed from the loading styles. In the autocomplete styles, the animation for SVG elements has been eliminated, impacting the visual dynamics of the user interface. These modifications simplify the visual behavior of loading indicators and remove animations from the autocomplete component.

Changes

Files Change Summary
packages/theme/src/autocomplete/index.less Adjusted padding formatting and removed SVG animation entirely.
packages/theme/src/loading/index.less Removed CSS animations and styles for loading indicators, including .circular, .path, and keyframes for loading-rotate and loading-dash.

Sequence Diagram(s)

(No sequence diagrams generated as the changes do not involve new features or modifications to control flow.)

Possibly related PRs

Suggested labels

bug

Poem

🐇
In a world of spins and twirls,
The loading dance has lost its swirls.
With colors bright, no more the chase,
A simpler path, a calmer space.
Hooray for change, let’s hop and play!
🌼✨

Tip

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 56e8819 and a673607.

Files ignored due to path filters (1)
  • packages/theme/src/svgs/loading-shadow.svg is excluded by !**/*.svg
Files selected for processing (1)
  • packages/theme/src/loading/index.less (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/theme/src/loading/index.less

@chenxi-20 chenxi-20 force-pushed the fix/loading-shadow-20240831 branch from a673607 to dc304a9 Compare September 9, 2024 08:10
@chenxi-20 chenxi-20 force-pushed the fix/loading-shadow-20240831 branch from dc304a9 to 132fa87 Compare September 9, 2024 08:12
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a673607 and bf58142.

Files ignored due to path filters (1)
  • packages/theme/src/svgs/loading-shadow.svg is excluded by !**/*.svg
Files selected for processing (2)
  • packages/theme/src/autocomplete/index.less (2 hunks)
  • packages/theme/src/loading/index.less (2 hunks)
Files skipped from review due to trivial changes (2)
  • packages/theme/src/autocomplete/index.less
  • packages/theme/src/loading/index.less

@chenxi-20 chenxi-20 force-pushed the fix/loading-shadow-20240831 branch from bf58142 to b32a6ba Compare September 9, 2024 10:42
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request (功能增强) labels Sep 9, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bf58142 and b32a6ba.

Files ignored due to path filters (1)
  • packages/theme/src/svgs/loading-shadow.svg is excluded by !**/*.svg
Files selected for processing (1)
  • packages/theme/src/autocomplete/index.less (3 hunks)
Files skipped from review due to trivial changes (1)
  • packages/theme/src/autocomplete/index.less

@zzcr zzcr merged commit 965232b into dev Sep 10, 2024
5 of 6 checks passed
@kagol kagol deleted the fix/loading-shadow-20240831 branch November 4, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants