Skip to content

feat(modal): [modal] modify demo #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2024
Merged

feat(modal): [modal] modify demo #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/sites/demos/pc/app/modal/default-grid-composition-api.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div class="content">
<tiny-button @click="visible = !visible" :reset-time="0">默认插槽</tiny-button>
<tiny-modal v-model="visible" :lock-scroll="false" show-footer width="1000">
<tiny-modal v-model="visible" :lock-scroll="false" show-footer width="1000" type="confirm">
<template #default>
<p class="test">test</p>
<tiny-grid :tooltip-config="{ 'append-to-body': true }" :data="tableData" :auto-resize="true">
Expand Down Expand Up @@ -50,5 +50,6 @@ const tableData = ref([
<style scoped>
.test {
margin-bottom: 16px;
color: #595959;
}
</style>
3 changes: 2 additions & 1 deletion examples/sites/demos/pc/app/modal/default-grid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div class="content">
<tiny-button @click="visible = !visible" :reset-time="0">默认插槽</tiny-button>
<tiny-modal v-model="visible" :lock-scroll="false" show-footer width="1000">
<tiny-modal v-model="visible" :lock-scroll="false" show-footer width="1000" type="confirm">
Copy link

@coderabbitai coderabbitai bot Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update documentation and add tests for the modal type change.

The addition of the type="confirm" attribute to the tiny-modal component aligns with the PR objective of modifying the modal demo. However, please ensure that you:

  1. Update the documentation to reflect this change in behavior from a default modal to a confirmation modal.
  2. Add tests to verify the expected behavior of the confirmation modal.

Do you want me to open a GitHub issue to track these tasks?

<template #default>
<p class="test">test</p>
<tiny-grid :tooltip-config="{ 'append-to-body': true }" :data="tableData" :auto-resize="true">
Expand Down Expand Up @@ -61,5 +61,6 @@ export default {
<style scoped>
.test {
margin-bottom: 16px;
color: #595959;
}
</style>