-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluent-editor): add format painter #2149
Conversation
WalkthroughThe pull request introduces enhancements to the Fluent Editor by modifying the toolbar configuration to include additional editing buttons: 'undo', 'redo', 'clean', and 'format-painter'. It also updates the CSS for SVG icons to ensure consistent sizing and adjusts the version of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
examples/sites/demos/pc/app/fluent-editor/options.vue (1)
Line range hint
1-80
: Update the documentation.As new toolbar options have been added, please ensure that the documentation is updated to reflect these changes and provide usage instructions for the new features.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- examples/sites/demos/pc/app/fluent-editor/options-composition-api.vue (1 hunks)
- examples/sites/demos/pc/app/fluent-editor/options.vue (1 hunks)
- packages/theme/src/fluent-editor/index.less (1 hunks)
- packages/vue/src/fluent-editor/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/theme/src/fluent-editor/index.less
Additional comments not posted (2)
packages/vue/src/fluent-editor/package.json (1)
14-14
: Verify the application with the newer version of@opentiny/fluent-editor
.The version bump of
@opentiny/fluent-editor
from~3.18.0
to~3.19.0
looks good. However, it's important to verify that the application still works as expected with the newer version, especially if there are any breaking changes.Run the following script to verify the application:
If any of the tests fail or if there are any breaking changes or issues found, please investigate and fix them before merging this PR.
examples/sites/demos/pc/app/fluent-editor/options-composition-api.vue (1)
19-19
: LGTM! The new toolbar buttons enhance the text editing capabilities.The addition of 'undo', 'redo', 'clean', and 'format-painter' buttons to the toolbar configuration is a great enhancement. These buttons will provide users with more comprehensive text manipulation options, improving the overall user experience.
The 'format-painter' button, in particular, aligns perfectly with the primary objective of this PR, which is to introduce a format painter feature. This feature will enable users to easily apply formatting from one part of the text to another, streamlining the editing process.
The changes are limited to the toolbar configuration and do not introduce any breaking changes. The code segment is syntactically correct and follows the existing code structure.
Great work on this enhancement!
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Style
Chores
@opentiny/fluent-editor
package to version~3.19.0
for potential new features and improvements.