feat(theme): modify variable names and add reset styles

[MomoPoppy]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Enhanced typography settings for specific elements with new font properties.
  • Introduced new CSS custom properties for icon colors, including definitions for disabled and control states.

• Bug Fixes

  • Consolidated icon color definitions for improved consistency across states.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the CSS styling within the theme package. It adds new CSS properties for typography in reset.less and updates icon color variables in vars.less. The changes streamline the icon color definitions and enhance the overall styling consistency across elements.

Changes

File Path	Change Summary
packages/theme/src/base/reset.less	Added font-size and font-family properties using CSS custom properties.
packages/theme/src/base/vars.less	Removed --tv-color-icon-stable; added --tv-color-icon-disabled and --tv-color-icon-control.

Possibly related PRs

• feat: optimize theme style variables #2157: This PR involves systematic renaming of CSS custom properties in vars.less, which is directly related to the changes made in the main PR that also modifies CSS variables in the same file.
• fix(theme): add tv-color-icon-stable #2175: This PR adds a new variable --tv-color-icon-stable in vars.less, which is relevant as the main PR modifies existing icon color variables and introduces new ones, indicating a direct connection in the context of icon styling.

Suggested labels

refactoring

Suggested reviewers

• zzcr

Poem

In the garden of style, we hop and play,
With fonts and colors brightening the day.
Icons now dance, their hues refined,
Typography sings, a joy intertwined.
A leap of change, so fresh and spry,
Together we flourish, oh my, oh my! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4895456 and 9e57170.

📒 Files selected for processing (1)

• packages/theme/src/base/reset.less (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/theme/src/base/reset.less

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/theme/src/base/reset.less (1)

45-47: LGTM! Consider adding a comment for clarity.

The addition of base typography styles using CSS custom properties is a good practice. It promotes consistency and makes theming easier. The naming convention of the custom properties (--tv-*) aligns well with the project's naming scheme.

Consider adding a brief comment above these new properties to explain their purpose, e.g.:

// Base typography styles
font-size: var(--tv-font-size-md);
font-family: var(--tv-font-family);
line-height: var(--tv-line-height-number);

This would enhance code readability and maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ffd3c7f and 4895456.

📒 Files selected for processing (2)

• packages/theme/src/base/reset.less (1 hunks)
• packages/theme/src/base/vars.less (1 hunks)

🔇 Additional comments not posted (5)

packages/theme/src/base/vars.less (5)

293-294: New icon color variables added

The addition of --tv-color-icon-disabled and --tv-color-icon-control variables enhances the flexibility of the design system for handling different icon states. This is a positive change that allows for more precise control over icon appearances.

---

293-294: Summary of changes and recommendations

The changes to the icon color variables in this file enhance the design system's flexibility for handling different icon states. The addition of --tv-color-icon-disabled and --tv-color-icon-control is a positive improvement.

To ensure the changes are fully implemented and consistent:

1. Verify the removal of --tv-color-icon-stable as mentioned in the AI summary.
2. Check for any other icon-related variables that might need updating for consistency.
3. Update any relevant documentation or style guides to reflect these changes.
4. Review the usage of these new variables across the project to ensure they are being utilized effectively.

These steps will help maintain the integrity and consistency of the design system while implementing these improvements.

Also applies to: 301-301

---

293-294: Ensure documentation is updated

With the addition of new icon color variables and potential removal of --tv-color-icon-stable, it's important to update any relevant documentation or style guides.

To check if there's any documentation that needs updating, run the following script:

This will help identify documentation files that might need to be updated to reflect the changes in icon color variables.

Also applies to: 301-301

---

293-294: Verify the removal of --tv-color-icon-stable

The AI summary mentions that --tv-color-icon-stable was removed, but I don't see its removal in the provided code. This might be because the removed lines are not shown in the diff.

To confirm this change, please run the following script:

This script will help verify if --tv-color-icon-stable was indeed removed and ensure consistency between the changes and the AI summary.

Also applies to: 301-301

✅ Verification successful

Verification Successful: --tv-color-icon-stable has been removed from packages/theme/src/base/vars.less.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the presence of --tv-color-icon-stable in the current and previous versions of the file

# Check current version
echo "Checking current version:"
rg --type css '--tv-color-icon-stable' packages/theme/src/base/vars.less

# Check previous version (assuming Git is used)
echo "Checking previous version:"
git show HEAD~1:packages/theme/src/base/vars.less | rg '--tv-color-icon-stable'

Length of output: 1126

---

Script:

#!/bin/bash
# Description: Corrected script to check for the presence of --tv-color-icon-stable in the current and previous versions of the file

# Check current version
echo "Checking current version:"
rg '--tv-color-icon-stable' packages/theme/src/base/vars.less

# Check previous version (assuming Git is used)
echo "Checking previous version:"
git show HEAD~1:packages/theme/src/base/vars.less | rg '--tv-color-icon-stable'

Length of output: 1115

---

Script:

#!/bin/bash
# Description: Corrected script to check for the presence of --tv-color-icon-stable in the current and previous versions of the file

# Check current version
echo "Checking current version:"
rg -- '--tv-color-icon-stable' packages/theme/src/base/vars.less

# Check previous version (assuming Git is used)
echo "Checking previous version:"
git show HEAD~1:packages/theme/src/base/vars.less | rg -- '--tv-color-icon-stable'

Length of output: 355

---

293-294: Consider updating related variables

The addition of --tv-color-icon-disabled and --tv-color-icon-control might affect other icon-related variables or their usage throughout the design system.

To ensure consistency, please run the following script to check for other icon-related variables and their usage:

This will help identify any other icon-related variables that might need updating for consistency with the new additions.

Also applies to: 301-301