fix(select): [select] modifying the loading icon issue

[MomoPoppy]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Introduced new props for enhanced configurability: searchable, showEmptyImage, inputBoxType, tagType, clearNoMatchValue, showLimitText, showProportion, clickExpand, maxVisibleRows, showAllTextTag, and allText.
  • Added support for conditional rendering of search input, limit text, and proportion text based on new props.
  • Enhanced tooltip and tag handling for improved user experience.
  • Introduced additional slots for greater customization options.
  • Improved event handling for dynamic interactions, including clearing search input.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the pc.vue component within the packages/vue/src/select/src directory. Significant modifications include the introduction of new props to enhance configurability, updates to the template for conditional rendering based on these props, refined tooltip and tag handling, improved event handling, adjustments to styling and class bindings, and the addition of new slots for customization. These updates collectively enhance the component's functionality and flexibility.

Changes

File Path

Change Summary

packages/vue/src/select/src/pc.vue

- Added new props: searchable, showEmptyImage, inputBoxType, tagType, clearNoMatchValue, showLimitText, showProportion, clickExpand, maxVisibleRows, showAllTextTag, allText. - Updated template for conditional rendering based on new props. - Refined tooltip and tag handling with optional chaining. - Updated event handling logic, including clearSearchText method. - Adjusted class bindings for styling. - Added support for a footer slot.

Possibly related PRs

• fix(select): [select] fix clear-no-match prop #2135: This PR addresses the clear-no-match property within the select component, which is directly related to the new clearNoMatchValue prop introduced in the main PR for the pc.vue component.
• refactor(select): [select] refactor theme vars for select #2232: This PR refactors theme variables for the select component, which includes changes to the pc.vue component, enhancing its configurability and functionality in line with the new props added in the main PR.

Suggested reviewers

• zzcr

Poem

In the meadow where rabbits play,
A new prop hops in today!
With search and tags, oh what a sight,
Our pc.vue shines so bright!
Custom slots for all to see,
A joyful change, oh let it be! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0b66817 and 760d4a5.

📒 Files selected for processing (1)

• packages/vue/src/select/src/pc.vue (4 hunks)

🧰 Additional context used

🔇 Additional comments (6)

packages/vue/src/select/src/pc.vue (6)

364-364: Review of Transition Component Usage

The transition component used here is correctly implemented with the name, @before-enter, and @after-leave attributes. This ensures smooth animations when the dropdown menu appears or disappears.

---

432-437: Enhancement: Implement Search Functionality in Dropdown

The addition of a search input within the dropdown enhances user experience by allowing users to filter options more efficiently.

---

488-488: Confirmation of Template Closure

The </template> tag correctly closes the previously opened <template>, ensuring proper component structure.

---

571-571: Enhancement: Added showEmptyImage Functionality

The introduction of the showEmptyImage feature provides a visual indicator when there are no options to display, improving user experience.

---

580-587: Avoid Using Optional Chaining (?.) in Vue 2 Templates

Optional chaining (?.) is not natively supported in Vue 2 templates and can cause compilation issues during the build process. To ensure compatibility and prevent potential errors, consider refactoring the expression to avoid using optional chaining in the template.

---

435-435: Verify the Usage of input-box-type

The property input-box-type="underline" is added to the tiny-input component. Ensure that the tiny-input component supports the input-box-type prop and that the value "underline" applies the desired styling.

Run the following script to verify if input-box-type is a valid prop in tiny-input:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e4a6369 and 0b66817.

📒 Files selected for processing (1)

• packages/vue/src/select/src/pc.vue (1 hunks)

🧰 Additional context used

[coderabbitai]

⚠️ Potential issue

Avoid Using Optional Chaining (?.) in Vue 2 Templates

Optional chaining (?.) is not natively supported in Vue 2 templates and can cause compilation issues during the build process. To ensure compatibility and prevent potential errors, consider refactoring the expression to avoid using optional chaining in the template.

Apply this diff to replace the optional chaining:

- :is="state.designConfig?.icons?.loadingIcon || 'icon-loading-shadow'"
+ :is="(state.designConfig && state.designConfig.icons && state.designConfig.icons.loadingIcon) || 'icon-loading-shadow'"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	:is="state.designConfig?.icons?.loadingIcon || 'icon-loading-shadow'"
	:is="(state.designConfig && state.designConfig.icons && state.designConfig.icons.loadingIcon) || 'icon-loading-shadow'"

[zzcr]

这种？.的操作符貌似在vue2的版本中无法识别，建议改成机器人提供的写法：state.designConfig && state.designConfig.icons && state.designConfig.icons.loadingIcon