Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): fix button cssvars #2334

Closed
wants to merge 2 commits into from

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Oct 21, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features
    • Updated CSS variable references in the card template for improved theming consistency.
  • Bug Fixes
    • Adjusted button icon color for better visibility across themes.
  • Chores
    • Removed unused files and empty mixins to streamline the codebase.
    • Restructured import statements for better organization of LESS files.

Copy link

coderabbitai bot commented Oct 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves the deletion of several LESS files related to button and card components, along with modifications to existing CSS variables. The changes include the removal of unused or empty mixins, the updating of CSS variable references for styling, and adjustments to import statements in the main index file. The overall structure of the theming system is refined, focusing on improving the consistency and organization of CSS variables across components.

Changes

File Path Change Summary
packages/theme/src/button/snippet.js Deleted the file which generated CSS variable declarations for button styling.
packages/theme/src/button/vars.less Updated the icon color variable --tv-Button-icon-color-default from var(--tv-color-icon-stable) to var(--tv-color-icon-control).
packages/theme/src/card-group/index.less Removed the import statement for vars.less and the mixin call .component-css-vars-amount().
packages/theme/src/card-group/vars.less Deleted the empty mixin .component-css-vars-amount().
packages/theme/src/card-item/index.less Deleted the file containing styles for the card item component.
packages/theme/src/card-item/vars.less Deleted the file containing CSS variable definitions for the card item component.
packages/theme/src/card-layout/index.less Deleted the file containing styles for the card layout component.
packages/theme/src/card-layout/vars.less Deleted the file containing CSS variable definitions for the card layout component.
packages/theme/src/card-template/index.less Updated CSS variable references from --ti- to --tv-CardTemplate- across various components.
packages/theme/src/card-template/vars.less Replaced the method .component-css-vars-card-template() with .inject-CardTemplate-vars(), updating variable declarations.
packages/theme/src/index.less Removed import statements for card-item/index.less and card-layout/index.less; added import for year-table/index.less.

Possibly related PRs

Suggested reviewers

  • zzcr

🐰 In a world of colors and themes so bright,
Buttons and cards now shine with delight.
Variables swapped, old files put away,
A fresh new look for a brighter day!
Hopping through styles, we cheer and we play,
For a vibrant design, hip-hip-hooray! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Oct 21, 2024
Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@shenjunjian shenjunjian deleted the refactor-card-cssvars branch October 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant