-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pager): [pager] fix pager demo e2e test #2339
Conversation
WalkthroughThe changes in this pull request involve a modification to a test case within the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
examples/sites/demos/pc/app/pager/before-page-change.spec.ts (1)
31-31
: Approved: Input value change improves test reliability.The change from '100' to '2' as the input for the pager's "goto" functionality is a good improvement. It tests a more realistic scenario and likely resolves issues with the previous test.
Consider adding an assertion after line 35 to verify that the current page is indeed 2 after the "goto" action. This would ensure the pager component correctly responds to the input. For example:
await expect(pager.locator('.tiny-pager__current')).toHaveText('2');This addition would make the test more robust by confirming the expected outcome of the "goto" action.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit