fix(tag): update tag's padding,border-radius #2458
Conversation
WalkthroughThe changes in this pull request involve multiple updates to the LESS variables for the Tag component's styling. Adjustments include modifications to font sizes, padding values, and border radii for various tag sizes (mini, small, medium). The changes reflect a transition from variable references to fixed values for certain properties, along with overall adjustments in sizing and spacing across different tag states. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (5)
packages/theme/src/tag/vars.less (5)
23-27: Consider maintaining design system consistency for padding values.
While using var(--tv-font-size-sm) improves design system consistency, switching from design system variables to fixed padding values (3px) might break this consistency. Consider using design system spacing variables instead.
- --tv-Tag-padding-x-mini: 3px;
+ --tv-Tag-padding-x-mini: var(--tv-space-2xs);38-42: Border radius change improves visual hierarchy, but consider system spacing.
The border-radius change from xs to sm improves the visual hierarchy. However, like the mini tag, consider using design system spacing variables for padding values instead of fixed pixels.
- --tv-Tag-padding-x-small: 7px;
+ --tv-Tag-padding-x-small: var(--tv-space-xs);62-62: Remove redundant inline comment.
The comment "//14" is redundant and could become outdated if the --tv-font-size-md variable changes. Consider removing it or documenting it properly.
- --tv-Tag-font-size-medium: var(--tv-font-size-md); //14
+ --tv-Tag-font-size-medium: var(--tv-font-size-md);70-72: Icon size reduction improves visual balance.
The reduction of icon size from 20px to 16px improves the visual proportions. However, consider using design system spacing variables for the icon padding.
- --tv-Tag-only-icon-padding-medium: 7px;
+ --tv-Tag-only-icon-padding-medium: var(--tv-space-xs);Line range hint 18-72: Consider maintaining design system consistency across all size variants.
There's a pattern of moving from design system variables to fixed pixel values across all tag sizes. While the specific values might meet current requirements, this approach could lead to:
- Inconsistency with other components
- Harder maintenance when design system spacing needs to change
- Potential issues with different screen densities
Consider creating new design system spacing variables if the current ones don't meet the tag component's needs, rather than using fixed values.
| --tv-Tag-padding-x: 11px; | ||
| // 默认标签垂直间距 | ||
| --tv-Tag-padding-y: 0.5px; | ||
| --tv-Tag-padding-y: 2.5px; | ||
| // 默认标签圆角 | ||
| --tv-Tag-border-radius: var(--tv-border-radius-sm); | ||
| --tv-Tag-border-radius: var(--tv-border-radius-md); |
There was a problem hiding this comment.
Avoid fractional pixel values for cross-browser consistency.
The 2.5px padding might render inconsistently across browsers. Consider rounding to whole pixels and using design system spacing variables.
- --tv-Tag-padding-y: 2.5px;
+ --tv-Tag-padding-y: 3px; /* or var(--tv-space-2xs) */📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| --tv-Tag-padding-x: 11px; | |
| // 默认标签垂直间距 | |
| --tv-Tag-padding-y: 0.5px; | |
| --tv-Tag-padding-y: 2.5px; | |
| // 默认标签圆角 | |
| --tv-Tag-border-radius: var(--tv-border-radius-sm); | |
| --tv-Tag-border-radius: var(--tv-border-radius-md); | |
| --tv-Tag-padding-x: 11px; | |
| // 默认标签垂直间距 | |
| --tv-Tag-padding-y: 3px; | |
| // 默认标签圆角 | |
| --tv-Tag-border-radius: var(--tv-border-radius-md); |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit