-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart): huiCharts打包替换为Chart #2622
Conversation
WalkthroughThe changes in this pull request primarily involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
internals/cli/src/commands/build/build-entry.ts (1)
116-117
: Consider adding a deprecation noticeThe component renaming in defaultComponents matches the changes in exportComponents. Consider adding a deprecation notice in the documentation to help users migrate from 'Huicharts' to 'Chart'.
Would you like me to help draft a deprecation notice or migration guide for this breaking change?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
internals/cli/src/commands/build/build-entry.ts
(2 hunks)
🔇 Additional comments (2)
internals/cli/src/commands/build/build-entry.ts (2)
106-107
: Verify the component renaming impact
The replacement of 'Huicharts' with 'Chart' in the export aliases changes how these components can be imported. This could be a breaking change if other parts of the codebase are using the old naming convention.
Let's check for existing imports that might be affected:
106-107
: Document version compatibility
Since this change modifies how components are exported and could affect imports, it should be properly versioned and documented.
Let's check the version bump and changelog:
Also applies to: 116-117
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes