-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form): [form] fix validate icon shrink when text very long #2663
Conversation
WalkthroughThis pull request involves two primary changes: updating the version of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme/src/form-item/index.less (1)
209-209
: LGTM! Consider adding a comment to document the flex-shrink fix.The addition of
flex-shrink: 0
correctly prevents the validation icon from shrinking when the error message is long, maintaining visual consistency. This is the right solution for the reported issue.Consider adding a comment to document why this fix is necessary:
.validate-icon { fill: var(--tv-FormItem-icon-color-error); margin-right: 4px; + /* Prevent icon from shrinking when error message is long */ flex-shrink: 0; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/theme/package.json
(1 hunks)packages/theme/src/form-item/index.less
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/theme/package.json
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
@opentiny/vue-theme
package to 3.20.1.