Skip to content

fix(pull-refresh): modify mobile bug #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix(pull-refresh): modify mobile bug #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/mobile/components/pull-refresh/src/mobile.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,14 @@
</template>

<script lang="tsx">
import { $prefix, setup, defineComponent, props } from '../../../vue-common'
import { $prefix, setup, defineComponent } from '../../../vue-common'
import { renderless, api } from './renderless/vue'
import { pullRefreshProps } from './pull-refresh'
import '@opentiny/vue-theme-mobile/pull-refresh/index.less'

export default defineComponent({
name: $prefix + 'PullRefresh',
componentName: 'PullRefresh',
props: pullRefreshProps,
setup(props, context) {
return setup({ props, context, renderless, api })
Expand Down
20 changes: 12 additions & 8 deletions packages/mobile/components/pull-refresh/src/pull-refresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,16 @@ export const pullRefreshProps = {
type: Boolean,
default: true
},

// mobile-first的props
headHeight: { type: [Number, String], default: $constants.DEFAULT_HEAD_HEIGHT },
pullingText: { type: String, default: t('ui.pullRefresh.pulling') },
loadingText: { type: String, default: $constants.STATUS.LOADING },
pullDistance: [Number, String],
loadingOptions: { type: Object, default: () => ({}) },
selfSimulate: { type: Boolean, default: false }
pullUpLoadingText: {
type: String,
default: ''
},
pullDownLoadingText: {
type: String,
default: ''
},
disabledPullUp: {
type: Boolean,
default: false
}
Comment on lines +44 to +55
Copy link

@coderabbitai coderabbitai bot Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

⚠️ Breaking Changes Detected: Props Removal Requires Documentation

While the new props (pullUpLoadingText, pullDownLoadingText, disabledPullUp) are well-structured, the removal of several critical props (headHeight, pullingText, loadingText, pullDistance, loadingOptions, selfSimulate) constitutes breaking changes that aren't mentioned in the PR description.

Action items:

  1. Document migration path for users relying on removed props
  2. Update PR description to reflect breaking changes
  3. Consider maintaining backward compatibility or implementing a deprecation strategy

Would you like me to help draft the migration guide or deprecation strategy?

}
Loading