fix(e2e): [tooltip,select] fix the security that causes e2e test failures. #2743
Conversation
|
Warning Rate limit exceeded@shenjunjian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 37 minutes and 41 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request encompasses changes across multiple files, focusing on input handling and component initialization. In the test file for a dropdown grid component, input fill operations have been modified to require specific space characters. The Popper dependency initialization has been updated to check for Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses issues causing e2e test failures by making three key fixes: 1) Adjusting the ResizeObserver in the popper file to prevent test failures, 2) Correcting spacing issues in the select example that affected tests, and 3) Modifying select behavior in nested trees to avoid unnecessary filtering. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| entry.target.popperVm.update() | ||
| } | ||
| const resizeOb = | ||
| isBrowser && typeof ResizeObserver === 'function' |
There was a problem hiding this comment.
Ensure that ResizeObserver is supported in the environment to prevent runtime errors. This change adds a check for the existence of ResizeObserver before instantiation.
zzcr
changed the title
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
zzcr
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
examples/sites/demos/pc/app/select/nest-grid-remote.spec.ts (3)
63-64: Provide context for " " usage.
It's not immediately clear why a single space matches all rows while two spaces match no rows. Consider adding an explanatory comment or constant clarifying this behavior to ease future maintenance.
83-83: Maintain consistency in test data input.
The duplication ofawait input.fill(' ' + ' ')across multiple tests suggests that a test helper function could reduce repetition and clearly convey intent.
131-131: Document reason for two spaces.
As with lines 63-64, clarify the decision to use two spaces for empty data results. This ensures test maintainability if the underlying product logic changes or extends.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
examples/sites/demos/pc/app/select/nest-grid-remote.spec.ts(3 hunks)packages/renderless/src/common/deps/popper.ts(1 hunks)packages/renderless/src/select/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: PR Unit Test
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
examples/sites/demos/pc/app/select/nest-grid-remote.spec.ts (1)
88-88: Ensure stable test coverage.
If' '(single space) is expected to match some data, confirm that this won't conflict with future changes or added rows. A single space can often be fragile as a matching pattern in real-world use cases.packages/renderless/src/select/index.ts (1)
219-224: Validate early return for Tree render type.
These lines prevent the default query filtering logic from running after tree-based filters. While this may prevent double-filter errors, ensure that no other side effects (e.g. additional event emissions or data transformations) were intended to occur indefaultOnQueryChange.packages/renderless/src/common/deps/popper.ts (1)
277-286: Guarded usage of ResizeObserver looks good.
Checking fortypeof ResizeObserver === 'function'avoids runtime errors in unsupported browsers. Verify that the fallback behavior (i.e.,null) gracefully degrades.
PR
1、修复popper文件中，出现ResizeObserver造成测试失败
2、修复select示例中，中文和数字添加了空格， 造成测试失败。
3、修复select嵌套树时，不需要select去过滤。
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Bug Fixes
Refactor