Skip to content

fix(pager): [pager] fix pager type error #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 14, 2025
Merged

fix(pager): [pager] fix pager type error #2801

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8281a7b
feat(pager): [pager] add change-compat to control whether trigger cha…
gimmyhehe Jan 11, 2025
83d54ba
Merge branch 'dev' of github.com:opentiny/tiny-vue into cgm/pager-cha…
gimmyhehe Jan 11, 2025
2588b14
fix(pager): fix internalPageSize error
gimmyhehe Jan 11, 2025
4fa6790
docs: add change-compat faq docs
gimmyhehe Jan 11, 2025
46ada6f
Merge branch 'dev' of github.com:opentiny/tiny-vue into cgm/pager-cha…
gimmyhehe Jan 14, 2025
da7f414
fix(pager): [pager] fix pager type error
gimmyhehe Jan 14, 2025
e791327
docs: 修改文档
gimmyhehe Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/renderless/types/pager.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ import type {
setTotal,
clickSizes,
watchInternalCurrentPage,
watchPageSizes,
watchCurrentPage,
watchInternalPageCount,
watchPageSize,
watchTotal,
watchShowSizes
watchShowSizes,
watchInternalPageSize,
Copy link

@petercat-assistant petercat-assistant bot Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new watchInternalPageSize and getInternalPageSize functions are correctly implemented and tested to prevent any runtime errors.

getInternalPageSize
} from '../src/pager'

export type IPagerProps = ExtractPropTypes<typeof pagerProps>
Expand Down Expand Up @@ -89,12 +89,12 @@ export interface IPagerApi {
setTotal: ReturnType<typeof setTotal>
clickSizes: ReturnType<typeof clickSizes>
watchInternalCurrentPage: ReturnType<typeof watchInternalCurrentPage>
watchPageSizes: ReturnType<typeof watchPageSizes>
watchCurrentPage: ReturnType<typeof watchCurrentPage>
watchInternalPageCount: ReturnType<typeof watchInternalPageCount>
watchPageSize: ReturnType<typeof watchPageSize>
watchTotal: ReturnType<typeof watchTotal>
watchShowSizes: ReturnType<typeof watchShowSizes>
watchInternalPageSize: ReturnType<typeof watchInternalPageSize>
getInternalPageSize: ReturnType<typeof getInternalPageSize>
}
export type IPagerRenderlessParams = ISharedRenderlessFunctionParams<never> & {
api: IPagerApi
Expand Down
Loading