-
Notifications
You must be signed in to change notification settings - Fork 330
fix(datePicker):[date-picker]Fix the display of datePicker deletion icon in dark themes. #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the styling of the picker component by modifying CSS rules in the theme and adjusting the template structure in the Vue component. The CSS changes include a shift to a dynamic class naming convention for SVG elements, the introduction of a visibility rule for icons, and a minor correction in selector formatting. In the Vue component, the trigger icon's attributes are reformatted for improved readability, without affecting functionality. No changes were made to public or exported entities. Changes
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS Optional dependencies cannot be installed without production dependencies 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses an issue with the datePicker component in dark themes by fixing the display of the deletion icon. The changes involve modifying the styles to ensure the icon is hidden on hover and focus, and adjusting the component class logic in the Vue template. Changes
|
packages/theme/src/picker/index.less
Outdated
| &:hover, | ||
| &:focus { | ||
| .tiny-svg-custom { | ||
| visibility: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the .tiny-svg-custom class is correctly applied to the elements that need to be hidden on hover and focus. This change hides the icon, but make sure it doesn't affect other functionalities.
5837c12 to
5190566
Compare
PR
修复暗色主题下datePicker删除图标显示
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit