Skip to content

Conversation

@discreted66
Copy link
Collaborator

@discreted66 discreted66 commented Mar 10, 2025

PR

修复暗色主题下datePicker删除图标显示

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced interactive visual feedback with refined hover and focus effects for the picker component.
    • Introduced conditional styling that dynamically adjusts the trigger icon's appearance based on current state.
    • Improved layout spacing for clearer visual alignment of icons.
    • Removed an unnecessary background style for a cleaner icon presentation.
    • Updated CSS class naming for SVG elements in the picker component.
    • Introduced visibility control for icons following the clear icon.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2025

Walkthrough

This pull request updates the styling of the picker component by modifying CSS rules in the theme and adjusting the template structure in the Vue component. The CSS changes include a shift to a dynamic class naming convention for SVG elements, the introduction of a visibility rule for icons, and a minor correction in selector formatting. In the Vue component, the trigger icon's attributes are reformatted for improved readability, without affecting functionality. No changes were made to public or exported entities.

Changes

File(s) Change Summary
packages/theme/.../index.less Updated SVG selector to .@{css-prefix}svg, added rule to hide .@{css-prefix}svg-size after .baseClearicon, corrected spacing in selector, removed background from .baseClearicon.
packages/vue/.../pc.vue Reformatted <component> element attributes for improved readability; functionality remains unchanged.

Possibly related PRs

Suggested reviewers

  • zzcr

Poem

I'm a hopping rabbit, with code in my stride,
Celebrating tweaks where style and logic collide.
On hover and focus, my SVG hides away,
While dynamic classes brighten the day.
A joyful leap in code—happy hops all the way! 🐰

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

 ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS  Optional dependencies cannot be installed without production dependencies


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5837c12 and 5190566.

📒 Files selected for processing (2)
  • packages/theme/src/picker/index.less (4 hunks)
  • packages/vue/src/picker/src/pc.vue (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/vue/src/picker/src/pc.vue
  • packages/theme/src/picker/index.less
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Mar 10, 2025
@petercat-assistant
Copy link

Walkthrough

This PR addresses an issue with the datePicker component in dark themes by fixing the display of the deletion icon. The changes involve modifying the styles to ensure the icon is hidden on hover and focus, and adjusting the component class logic in the Vue template.

Changes

File Summary
packages/theme/src/picker/index.less Added CSS rules to hide the deletion icon on hover and focus. Adjusted selector spacing for better readability.
packages/vue/src/picker/src/pc.vue Updated component class logic to conditionally apply a custom class based on the display value.

&:hover,
&:focus {
.tiny-svg-custom {
visibility: hidden;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the .tiny-svg-custom class is correctly applied to the elements that need to be hidden on hover and focus. This change hides the icon, but make sure it doesn't affect other functionalities.

@discreted66 discreted66 force-pushed the darkTheme4 branch 2 times, most recently from 5837c12 to 5190566 Compare March 10, 2025 03:42
@zzcr zzcr merged commit ec4f860 into opentiny:dev Mar 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants