fix(base-select): [base-select,select] modify test cases #3141
Conversation
WalkthroughThis pull request updates the validation in two dropdown component tests. The expected CSS background color in the tests has been changed from Changes
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/base-select/popup-style-position.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/select/popup-style-position.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request modifies the test cases for the Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| await expect(dropdown).toHaveCount(1) | ||
| await expect(dropdown).toHaveClass(/drop/) | ||
| await expect(dropdown).toHaveCSS('background-color', 'rgb(213, 232, 255)') | ||
| await expect(dropdown).toHaveCSS('background-color', 'rgb(255,255, 255)') |
There was a problem hiding this comment.
Ensure that the new background color value rgb(255, 255, 255) is correct and aligns with the intended design specifications. If this change is not intentional, please verify the expected value.
MomoPoppy
force-pushed
the
MomoPoppy/fix-base-selct-test-0318
branch
from
d5bd3d1 to
90cd97d
Compare
MomoPoppy
changed the title
MomoPoppy
changed the title
MomoPoppy
force-pushed
the
MomoPoppy/fix-base-selct-test-0318
branch
from
90cd97d to
be70c06
Compare
3 participants
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit