fix(checkbox): [checkbox] Adapt to dark themes

[Youyou-smiles]

fix(checkbox): [checkbox] Adapt to dark themes

Summary by CodeRabbit

• Style
  • Enhanced the visual appearance of checkboxes in their disabled state.
  • Introduced a dynamic theming variable to allow customizable icon colors when checkboxes are disabled.

[coderabbitai]

Walkthrough

This change updates the checkbox component’s styling by replacing a hardcoded fill color in the disabled state with a CSS variable. A new CSS variable is introduced to determine the inverse disabled color for the checkbox icon. No modifications have been made to exported or public declarations.

Changes

File(s)	Change Summary
packages/.../checkbox/index.less, packages/.../checkbox/vars.less	Updated the disabled state styling by replacing the hardcoded #FFFFFF fill color with var(--tv-Checkbox-icon-inverse-disabled) and added the new variable --tv-Checkbox-icon-inverse-disabled (mapped to var(--tv-color-bg-inverse-disabled)) in vars.less.

Possibly related PRs

• feat(checkbox): [checkbox] Component dark theme adaptation #3007: Addresses similar modifications to the disabled state styles of checkbox icons.
• fix(site): official website adapts to the dark mode. #2956: Involves updates to CSS variables for theming, aligning with this PR’s approach.
• feat(checkbox): [checkbox] Adapting to the SMB theme #2130: Introduces a new CSS variable for the checkbox component that is directly utilized by this change.

Suggested labels

enhancement

Suggested reviewers

• MomoPoppy
• zzcr

Poem

I'm a hopping rabbit, excited for code anew,
Cheering for CSS variables that bring a fresher view.
Checkboxes now shimmer in their disabled state,
With colors that adjust, adapting just great.
Happy leaps of code make every theme feel true!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/theme/src/checkbox/vars.less (1)

51-52: Missing Semicolon in New Variable Definition
The new variable --tv-Checkbox-icon-inverse-disabled is defined correctly to reference var(--tv-color-bg-inverse-disabled), but the line is missing a terminating semicolon. This may lead to syntax issues in LESS compilation. Consider updating the line as shown below.

-  --tv-Checkbox-icon-inverse-disabled: var(--tv-color-bg-inverse-disabled)
+  --tv-Checkbox-icon-inverse-disabled: var(--tv-color-bg-inverse-disabled);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a03127 and 4a8ba13.

📒 Files selected for processing (2)

• packages/theme/src/checkbox/index.less (1 hunks)
• packages/theme/src/checkbox/vars.less (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (1)

packages/theme/src/checkbox/index.less (1)

182-188: CSS Variable for Dark Theme Disabled Icon
The change correctly replaces the previously hardcoded fill color with the CSS variable var(--tv-Checkbox-icon-inverse-disabled), which facilitates dynamic styling for dark themes. Please ensure that the new variable is defined and maintained consistently in your theme configuration.