Skip to content

fix(tooltip): [tooltip] update dark theme #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
+5 −12
Merged

fix(tooltip): [tooltip] update dark theme #3216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/theme/src/tooltip/vars.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,18 @@
--tv-Tooltip-popper-success-border-color: var(--tv-color-success-border, #5cb300);

// dark主题弹框背景色
--tv-Tooltip-popper-dark-bg-color: var(--tv-color-bg-dark, #191919);
--tv-Tooltip-popper-dark-bg-color: var(--tv-color-bg-dark-1);
Copy link

@petercat-assistant petercat-assistant bot Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new variable --tv-color-bg-dark-1 is defined and used consistently across the theme to avoid any undefined variable issues.

// dark主题弹框文本色
--tv-Tooltip-popper-dark-text-color: var(--tv-color-text-inverse, #ffffff);
// dark主题|禁用时弹框边框色
--tv-Tooltip-popper-dark-border-color: var(--tv-color-border-hover, #191919);

// light主题弹框背景色
--tv-Tooltip-popper-light-bg-color: var(--tv-color-bg-inverse, #ffffff);
--tv-Tooltip-popper-light-bg-color: var(--tv-color-bg-2);
Copy link

@petercat-assistant petercat-assistant bot Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new variable --tv-color-bg-2 is defined and used consistently across the theme to avoid any undefined variable issues.

// light主题|禁用弹框文本色
--tv-Tooltip-popper-light-text-color: var(--tv-color-text-inverse-black, #191919);
--tv-Tooltip-popper-light-text-color: var(--tv-color-text);
Copy link

@petercat-assistant petercat-assistant bot Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new variable --tv-color-text is defined and used consistently across the theme to avoid any undefined variable issues.

// light主题|禁用时弹框边框色
--tv-Tooltip-popper-light-border-color: var(--tv-Tooltip-popper-light-bg-color);
--tv-Tooltip-popper-light-border-color: var(--tv-Tooltip-popper-normal-bg-color);
Copy link

@petercat-assistant petercat-assistant bot Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new variable --tv-Tooltip-popper-normal-bg-color is defined and used consistently across the theme to avoid any undefined variable issues.


// 弹框阴影
--tv-Tooltip-box-shadow: var(--tv-shadow-2-down, 0 2px 12px 0 rgba(0, 0, 0, 0.16));
Expand Down
9 changes: 1 addition & 8 deletions packages/theme/src/transfer/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,18 +151,14 @@

&__body {
position: relative;
height: var(--tv-Transfer-panel-body-height);
height: var(--tv-Transfer-panel-body-height);
overflow: auto;
text-align: left;
padding-right: var(--tv-Transfer-panel-body-padding-right);
padding-left: var(--tv-Transfer-panel-body-padding-left);
.tiny-table.simple table tbody tr:has(td svg.is-check) {
background-color: var(--tv-Transfer-panel-item-active-bg-color);
}
&.is-with-footer {
padding-bottom: var(--tv-Transfer-panel-body-footer-padding-bottom);
height: var(--tv-Transfer-panel-body-footer-height);
}

.@{tree-prefix-cls} {
height: var(--tv-Transfer-panel-body-tree-height);
Expand Down Expand Up @@ -348,9 +344,6 @@
padding-top: var(--tv-Transfer-footer-padding-top);
padding-bottom: var(--tv-Transfer-footer-padding-bottom);
border-top: 1px solid var(--tv-Transfer-footer-border-color);
position: absolute;
bottom: 0;
left: 0;
width: 100%;
z-index: 1;

Expand Down
Loading