fix(grid): [grid] fix viewType change table column width error #3273
Conversation
WalkthroughThe pull request modifies the conditional logic inside the Changes
Sequence Diagram(s)sequenceDiagram
participant Grid as Grid Component
participant Layout as Layout Manager
Grid->>Grid: Trigger viewType change
alt viewType === V_MF
Grid->>Layout: Recalculate table layout
else
Grid-->>Grid: Skip recalculation
end
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/grid/src/grid/grid.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Walkthrough此PR修复了从卡片或列表视图切换到表格视图时，列宽未自动调整的问题。通过在切换到表格视图时调用 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| // 在全屏状态下切换到表格视图时额外刷新一次表格布局，解决此场景下列宽未自动撑开问题 | ||
| if (value === V_MF && this.fullScreenClass) { | ||
| // 解决从卡片、列表视图切换至表格视图后，列宽未自动撑开问题 | ||
| if (value === V_MF) { |
There was a problem hiding this comment.
The condition if (value === V_MF) ensures that the recalculation is triggered when switching to the table view, addressing the issue of column width not adjusting automatically. This change removes the unnecessary check for this.fullScreenClass, simplifying the logic.
WalkthroughThis PR fixes an issue where column width is not automatically adjusted when switching from card or list view to table view. Make sure the column width is set correctly by calling the Changes
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/vue/src/grid/src/grid/grid.ts (1)
217-220: Improvement to view type change behaviorThe updated conditional logic correctly addresses the issue with column widths not expanding automatically when switching from card or list views to table view. The removal of the
this.fullScreenClassdependency is appropriate, as the column width adjustment should happen regardless of whether the grid is in full-screen mode or not.Consider adding a brief comment in the
recalculatecall to clarify why thetrueparameter is being passed:if (value === V_MF) { - this.$nextTick(() => this.recalculate(true)) + this.$nextTick(() => this.recalculate(true)) // Force full recalculation to ensure proper column widths }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/vue/src/grid/src/grid/grid.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
PR
解决从卡片、列表视图切换至表格视图后，列宽未自动撑开问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit