Skip to content

Conversation

@gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Apr 11, 2025

PR

修复包裹span后,word-break样式不生效问题

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Refactor
    • Streamlined the text display in input components for a cleaner and more maintainable layout while preserving the current user experience.

@coderabbitai
Copy link

coderabbitai bot commented Apr 11, 2025

Walkthrough

This pull request updates two Vue component templates by modifying the HTML structure. In both the mobile-first and PC versions, the <span> element displaying state.displayOnlyText has been simplified. The separate closing tag has been removed and its content merged into the opening tag, resulting in a cleaner HTML layout. No changes have been made to the application logic or exported entities.

Changes

Files Change Summary
packages/vue/.../mobile-first.vue, packages/vue/.../pc.vue Simplified the <span> element by merging the closing tag with the state.displayOnlyText interpolation, streamlining the template.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • zzcr

Poem

I hop through code with a joyful bound,
Merging <span> tags with a cleaner sound.
Text and tag combine in a single, neat line,
Simplifying the view, oh so divine!
My rabbit heart leaps at this refined byte,
Celebrating changes in our code's moonlit night 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/input/src/pc.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/vue/src/input/src/mobile-first.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24baa79 and 13f2f47.

📒 Files selected for processing (2)
  • packages/vue/src/input/src/mobile-first.vue (1 hunks)
  • packages/vue/src/input/src/pc.vue (1 hunks)
🔇 Additional comments (2)
packages/vue/src/input/src/mobile-first.vue (1)

298-304: Consolidate display-only text span and verify proper tag closure
The changes merge the separate “more” button span with the main {{ state.displayOnlyText }} into a single continuous span. This simplification should help ensure that CSS styles such as word-break are correctly applied, resolving the reported issue.

Please double-check that no extraneous > characters remain in the merged output (for example, verify that the extra > after {{ t('ui.input.more') }} is removed so that the final rendered HTML is correct).

packages/vue/src/input/src/pc.vue (1)

182-184: Simplify display-only text span structure in PC version
The revised HTML in this file now merges the “more” button and the {{ state.displayOnlyText }} content into one unified span. This change is consistent with the mobile-first refactor and should address the word-break style issue by avoiding unnecessary nested span elements.

Please ensure that the merged structure does not inadvertently introduce extra closing characters (such as an extra > after {{ t('ui.input.more') }}) that might affect the rendered output.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 11, 2025
@petercat-assistant
Copy link

Walkthrough

此PR修复了在包裹span元素后,word-break样式不生效的问题。通过调整span标签的结构,确保文本在需要时能够正确换行。

Changes

文件 概要
packages/vue/src/input/src/mobile-first.vue, packages/vue/src/input/src/pc.vue 修复了span标签结构,确保state.displayOnlyText能够正确应用word-break样式。

>{{ t('ui.input.more') }}></span
>
<span>{{ state.displayOnlyText }}</span>
>{{ state.displayOnlyText }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修复了span标签结构,确保state.displayOnlyText能够正确应用word-break样式。

>{{ t('ui.input.more') }}></span
>
<span>{{ state.displayOnlyText }}</span>
>{{ state.displayOnlyText }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修复了span标签结构,确保state.displayOnlyText能够正确应用word-break样式。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Walkthrough

This PR fixes the issue where word-break styles do not take effect after wrapping span elements. By adjusting the structure of the span tag, ensure that the text can be wrapped correctly when needed.

Changes

Documents Summary
packages/vue/src/input/src/mobile-first.vue, packages/vue/src/input/src/pc.vue Fixed the span tag structure to ensure that state.displayOnlyText can correctly apply word-break style.

@zzcr zzcr merged commit fc2b2f8 into dev Apr 11, 2025
11 checks passed
@kagol kagol deleted the cgm/fix-input-span-wrap branch April 14, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants