feat(color-picker): color-picker component #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagol
reviewed
Aug 13, 2023
kagol
reviewed
Aug 13, 2023
kagol
reviewed
Aug 13, 2023
|
@GaoNeng-wWw PR描述里可以列下实现了哪些功能，贴几个效果图 |
@GaoNeng-wWw In the PR description, you can list which functions have been realized, and post a few renderings |
kagol
reviewed
Aug 13, 2023
kagol
reviewed
Aug 13, 2023
kagol
previously approved these changes
Aug 14, 2023
zzcr
reviewed
Aug 14, 2023
kagol
reviewed
Aug 16, 2023
| @@ -373,6 +376,7 @@ export default { | |||
| CheckboxGroup, | |||
| Collapse, | |||
| CollapseItem, | |||
| ColorPicker, | |||
There was a problem hiding this comment.
这个 mobile-first 是用来做多端适配的，color-picker组件不涉及，不需要修改这个文件
kagol
reviewed
Aug 16, 2023
| @@ -0,0 +1,64 @@ | |||
| import {IColorPickerRef as Ref} from '@/types'; | |||
There was a problem hiding this comment.
Suggested change
| import {IColorPickerRef as Ref} from '@/types'; | |
| import { IColorPickerRef as Ref } from '@/types'; |
kagol
approved these changes
Aug 16, 2023
|
@GaoNeng-wWw 建议支持通过直接点击色板来取色，目前必须要拖动小圆点 |
@GaoNeng-wWw suggested to support picking colors by directly clicking on the swatches |
|
@GaoNeng-wWw 构建之后的产物，确定、取消按钮没了，应该是没有引入 复现步骤：
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information